Bug 903999

Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[-]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[-]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[-]: If the package is under multiple licenses, the licensing breakdown must
     be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.

Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


$ rpmlint ./perl-Module-Load-Conditional-0.54-1.fc19.* perl-Module-Load-Conditional.spec
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpm -qp --requires ./perl-Module-Load-Conditional-0.54-1.fc19.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.16.2)
      1 perl(Carp)
      1 perl(Config)
      1 perl(Exporter)
      1 perl(File::Spec)
      1 perl(FileHandle)
      1 perl(Locale::Maketext::Simple)
      1 perl(Module::CoreList) >= 2.22
      1 perl(Module::Load) >= 0.11
      1 perl(Module::Metadata) >= 1.000005
      1 perl(Params::Check)
      1 perl(constant)
      1 perl(strict)
      1 perl(vars)
      1 perl(version) >= 0.69
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Requires ok.

$ rpm -qp --provides ./perl-Module-Load-Conditional-0.54-1.fc19.noarch.rpm | sort | uniq -c
      1 perl(Module::Load::Conditional) = 0.54
      1 perl-Module-Load-Conditional = 0.54-1.fc19
Provides ok.

MD5-sum check
-------------
http://www.cpan.org/authors/id/B/BI/BINGOS/Module-Load-Conditional-0.54.tar.gz :
  CHECKSUM(SHA256) this package     : 1b99c78a074b732dfd5f7e627102ef4789695e370da671e4c614754aa8ed5b8f
  CHECKSUM(SHA256) upstream package : 1b99c78a074b732dfd5f7e627102ef4789695e370da671e4c614754aa8ed5b8f
Ok.


Package is good.
Approved.

New Package SCM Request
=======================
Package Name: perl-Module-Load-Conditional
Short Description: Looking up module information and loading at run-time
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Unretired.

Waiting on unblocking https://fedorahosted.org/rel-eng/ticket/5489.

Thank you for the review and the repository.