Bug 904639
| Summary: | Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mamoru TASAKA <mtasaka> |
| Component: | Package Review | Assignee: | Josef Stribny <jstribny> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dkholia, hhorak, jstribny, notting, package-review |
| Target Milestone: | --- | Flags: | jstribny:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-10-04 09:22:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 892314 | ||
| Bug Blocks: | 904640 | ||
|
Description
Mamoru TASAKA
2013-01-26 18:49:30 UTC
This packge depends on rubygem-unf_ext, review request bug 892314 . Local mock build log for F-19: http://mtasaka.fedorapeople.org/Review_request/mechanize-related/MOCK-rubygem-unf.log http://mtasaka.fedorapeople.org/Review_request/mechanize-related/rubygem-unf.spec http://mtasaka.fedorapeople.org/Review_request/mechanize-related/rubygem-unf-0.1.0-1.fc.src.rpm * Fri Mar 22 2013 Mamoru TASAKA <mtasaka> - 0.1.0-1 - 0.1.0 Mock build log on F-20: http://mtasaka.fedorapeople.org/Review_request/mechanize-related/MOCK-rubygem-unf.log http://mtasaka.fedorapeople.org/Review_request/mechanize-related/rubygem-unf.spec http://mtasaka.fedorapeople.org/Review_request/mechanize-related/rubygem-unf-0.1.1-1.fc.src.rpm * Mon Apr 29 2013 Mamoru TASAKA <mtasaka> - 0.1.1-1 - 0.1.1 Mock build for F-19: http://mtasaka.fedorapeople.org/Review_request/mechanize-related/MOCK-rubygem-unf.log I will take it for a review. 1, There is a newer upstream version (0.1.2).
2, The %description section of -doc sub-package should end up with a dot(.).
3, You should use a macro %{gem_libdir} for lib dir instead of %{gem_instdir}/lib/
4, And again license file is not separately listed. This requires more work in the end (for me to check it, for you to check it with every update of the gem) and it's prone to error.
Otherwise rpmlint doesn't complain, package builds, installs and runs. Please fix the issues above so I can approve.
Thank you for comments! http://mtasaka.fedorapeople.org/Review_request/mechanize-related/rubygem-unf-0.1.2-1.fc.src.rpm http://mtasaka.fedorapeople.org/Review_request/mechanize-related/rubygem-unf.spec * Thu Oct 3 2013 Mamoru TASAKA <mtasaka> - 0.1.2-1 - 0.1.2 (In reply to Josef Stribny from comment #5) > 1, There is a newer upstream version (0.1.2). - Updated. > 2, The %description section of -doc sub-package should end up with a dot(.). - Fixed > 3, You should use a macro %{gem_libdir} for lib dir instead of > %{gem_instdir}/lib/ - Well, I prefer to use %{gem_instdir}/lib/ because using %{gem_libdir} makes it difficult to show that %{gem_libdir} is the subdirectory of %{gem_instdir} (i.e. the parent directory of %{gem_libdir} is properly owned), however modified. > 4, And again license file is not separately listed. This requires more work > in the end (for me to check it, for you to check it with every update of the > gem) and it's prone to error. - I always check this... (i.e. I always unpack both the previous version and the new version of tarball / gem / etc, take diff to check what actually changed, judge if it can safely be upgraded.) > I always check this... (i.e. I always unpack both the previous version
> and the new version of tarball / gem / etc, take diff to check what
> actually changed, judge if it can safely be upgraded.)
I believe you and it's a right thing to do :). But someone working on the package in the future can overlook it, that's my point :).
Thanks for the fixes ==> APPROVED.
Thank you! New Package SCM Request ======================= Package Name: rubygem-unf Short Description: Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby Owners: mtasaka Branches: f18 f19 f20 InitialCC: Git done (by process-git-requests). Rebuilt for all branches, push requested for F-20 and below, closing. Thank you for reviewing and git procedure. |