Bug 904840

Summary: Hot-unplug fails when unplug nic and changing MAC address.
Product: Red Hat Enterprise Virtualization Manager Reporter: Meni Yakove <myakove>
Component: ovirt-engineAssignee: Alona Kaplan <alkaplan>
Status: CLOSED CURRENTRELEASE QA Contact: Meni Yakove <myakove>
Severity: high Docs Contact:
Priority: medium    
Version: unspecifiedCC: acathrow, dyasny, iheim, lpeer, masayag, Rhev-m-bugs, sgrinber, yeylon, ykaul
Target Milestone: ---   
Target Release: 3.2.0   
Hardware: x86_64   
OS: All   
Whiteboard: network
Fixed In Version: sf10 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 922807, 948448    
Attachments:
Description Flags
engine.log
none
vdsm.log none

Description Meni Yakove 2013-01-27 19:53:00 UTC
Created attachment 688597 [details]
engine.log

Description of problem:
Hot-unplug fails when trying to unplug and change MAC address for nic under running VM 

Version-Release number of selected component (if applicable):
rhevm-3.2.0-5.el6ev.noarch
vdsm-4.10.2-4.0.el6ev.x86_64

How reproducible:
100%

Steps to Reproduce:
1.Create VM with 1 nic and start the VM
2.while the VM is up hot-unplug the nic and change the MAC address (one operation)

  
Actual results:
Error and operation fails.

Expected results:
operation should pass without any errors.

Additional info:
from engine - 2013-01-27 21:34:38,993 ERROR [org.ovirt.engine.core.bll.network.vm.ActivateDeactivateVmNicCommand] (ajp-/127.0.0.1:8702-15) [7de5865d] Command org.ovirt.engine.core.bll.network.vm.ActivateDea
ctivateVmNicCommand throw Vdc Bll exception. With error message VdcBLLException: org.ovirt.engine.core.vdsbroker.vdsbroker.VDSErrorException: VDSGenericException: VDSErrorException: Failed to
HotUnplugNicVDS, error = Unexpected exception

from VDSM - Thread-29801::ERROR::2013-01-28 09:34:24,803::libvirtvm::1717::vm.Vm::(hotunplugNic) vmId=`0e0147fb-4ebe-4c45-a530-2ee76120a5aa`::Hotunplug NIC failed - NIC not found: {'nicModel': 'pv', 'macA
ddr': '00:14:14:14:14:14', 'linkActive': 'true', 'network': 'rhevm', 'filter': 'vdsm-no-mac-spoofing', 'specParams': {}, 'deviceId': 'f8011197-741e-4ba2-9449-255dd4974b6e', 'address': {'bus':
'0x00', ' slot': '0x06', ' domain': '0x0000', ' type': 'pci', ' function': '0x0'}, 'device': 'bridge', 'type': 'interface'}
Thread-29801::ERROR::2013-01-28 09:34:24,806::BindingXMLRPC::932::vds::(wrapper) unexpected error
Traceback (most recent call last):
  File "/usr/share/vdsm/BindingXMLRPC.py", line 918, in wrapper
    res = f(*args, **kwargs)
  File "/usr/share/vdsm/BindingXMLRPC.py", line 263, in vmHotunplugNic
    return vm.hotunplugNic(params)
  File "/usr/share/vdsm/API.py", line 407, in hotunplugNic
    return curVm.hotunplugNic(params)
  File "/usr/share/vdsm/libvirtvm.py", line 1718, in hotunplugNic
    hooks.after_nic_hotunplug_fail(nicXml, self.conf)
UnboundLocalError: local variable 'nicXml' referenced before assignment

Comment 1 Meni Yakove 2013-01-27 19:59:04 UTC
Created attachment 688598 [details]
vdsm.log

Comment 2 Meni Yakove 2013-03-11 14:16:00 UTC
Verified on rhevm-3.2.0-10.14.beta1.el6ev.noarch

Comment 3 Itamar Heim 2013-06-11 08:56:55 UTC
3.2 has been released

Comment 4 Itamar Heim 2013-06-11 08:57:00 UTC
3.2 has been released

Comment 5 Itamar Heim 2013-06-11 08:57:02 UTC
3.2 has been released

Comment 6 Itamar Heim 2013-06-11 08:59:24 UTC
3.2 has been released

Comment 7 Itamar Heim 2013-06-11 09:28:59 UTC
3.2 has been released