Bug 905593

Summary: FTBFS: webkitgtk3-1.11.4 fails to build with --disable-jit
Product: [Fedora] Fedora Reporter: Karsten Hopp <karsten>
Component: webkitgtk3Assignee: Matthias Clasen <mclasen>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: high    
Version: rawhideCC: blc, dan.mashal, fedora, kalevlember, mclasen, tpopela
Target Milestone: ---   
Target Release: ---   
Hardware: powerpc   
OS: Linux   
URL: https://bugs.webkit.org/show_bug.cgi?id=107323
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-02-18 08:00:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
compressed build.log
none
proposed patch none

Description Karsten Hopp 2013-01-29 17:51:14 UTC 
Created attachment 689972 [details]
compressed build.log

Description of problem:
webkitgtk3-1.11.4-3.fc19 fails to build on ARM, s390* and ppc* as some intrinsic functions are defined inside '#if ENABLED(JIT)' and they are used without this protection.
P.e.:

Source/JavaScriptCore/bytecode/CallLinkStatus.cpp: In member function 'JSC::Intrinsic JSC::CallLinkStatus::intrinsicFor(JSC::CodeSpecializationKind) const':
Source/JavaScriptCore/bytecode/CallLinkStatus.cpp:80:26: error: 'class JSC::ExecutableBase' has no member named 'intrinsicFor'



Version-Release number of selected component (if applicable):
webkitgtk3-1.11.4-3.fc19

How reproducible:
always

Steps to Reproduce:
1. ppc-koji build --scratch f19 webkitgtk3-1.11.4-3.fc19.src.rpm
2.
3.
  
Actual results:
http://ppc.koji.fedoraproject.org/koji/getfile?taskID=884250&name=build.log

Expected results:


Additional info:
This has been reported upstream, but afaik without a fix yet:
https://bugs.webkit.org/show_bug.cgi?id=107323
Comment 1 Karsten Hopp 2013-01-29 17:53:37 UTC 
Created attachment 689974 [details]
proposed patch

even though a build succeeds with this patch, I'm not sure if this the right approach to fix this issue. Please review....
Comment 2 Brendan Conoboy 2013-01-30 03:44:28 UTC 
This also affects ARM.
Comment 3 Karsten Hopp 2013-02-07 10:54:43 UTC 
Interesting, the link in comment #1 doesn't show the complete patch, use https://bugzilla.redhat.com/attachment.cgi?id=689974 instead
Comment 4 Kalev Lember 2013-02-14 20:15:24 UTC 
I think the best way forward with this would be to post the fix to the upstream ticket. I don't think we have anyone on Fedora's side who's familiar with the javascriptcore code.
Comment 5 Tomas Popela 2013-02-18 08:00:51 UTC 
Actually fix for this bug landed in upstream on 3. January and is included in webkitgtk 1.11.5 release.