Bug 905615

Summary:	Review Request: gammaray - A tool for examining internals of Qt applications
Product:	[Fedora] Fedora	Reporter:	Daniel Vrátil <dvratil>
Component:	Package Review	Assignee:	Jan Grulich <jgrulich>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jeischma, jgrulich, notting, package-review
Target Milestone:	---	Flags:	jgrulich: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-02-20 04:02:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Daniel Vrátil 2013-01-29 18:46:42 UTC

Spec URL: http://people.fedoraproject.org/~dvratil/spec/gammaray.spec
SRPM URL: http://people.fedoraproject.org/~dvratil/spec/gammaray-1.3.0-1.fc18.src.rpm (226M)
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4912393

Description: A tool to poke around in a Qt-application and also to manipulate
the application to some extent. It uses various DLL injection
techniques to hook into an application at run-time and provide
access to a lot of interesting information.

Fedora Account System Username: dvratil


The package needs Qt sources in order to have access to some private headers and sources that are not available in qt-devel and qt-devel-private

Comment 1 Jan Grulich 2013-02-07 13:02:02 UTC

Documentation should be in -doc subpackage, not in -docs. Use %global instead of %define (it's not necessary but it's between "should" items in fedora-review)

Comment 2 Daniel Vrátil 2013-02-07 15:01:19 UTC

Spec URL: http://people.fedoraproject.org/~dvratil/spec/gammaray.spec
SRPM URL: http://people.fedoraproject.org/~dvratil/spec/gammaray-1.3.0-2.fc18.src.rpm 

* Thu Feb 05 2013 Dan Vrátil <dvratil> 1.3.0-2
 - rename docs subpackage to doc
 - use %%global instead of %%define

Comment 3 Jan Grulich 2013-02-08 20:44:51 UTC

licensecheck - mostly LGPLv2+
fedora-review - no issues from my point of view

rpmlint
========
Checking: gammaray-1.3.0-2.fc18.x86_64.rpm
          gammaray-devel-1.3.0-2.fc18.x86_64.rpm
          gammaray-doc-1.3.0-2.fc18.noarch.rpm
gammaray.x86_64: E: invalid-soname /usr/lib64/gammaray_probe.so gammaray_probe.so
gammaray.x86_64: E: invalid-soname /usr/lib64/libgammaray_widget_export_actions.so libgammaray_widget_export_actions.so
gammaray-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 2 errors, 1 warnings.

Everything should be ok.

Comment 4 Daniel Vrátil 2013-02-09 10:52:27 UTC

New Package SCM Request
=======================
Package Name: gammaray
Short Description: A tool for examining internals of Qt applications
Owners: dvratil
Branches: f17 f18
InitialCC:

Comment 5 Gwyn Ciesla 2013-02-09 20:51:37 UTC

Git done (by process-git-requests).

Comment 6 Fedora Update System 2013-02-10 23:20:45 UTC

gammaray-1.3.0-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/gammaray-1.3.0-2.fc18

Comment 7 Fedora Update System 2013-02-10 23:20:57 UTC

gammaray-1.3.0-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/gammaray-1.3.0-2.fc17

Comment 8 Fedora Update System 2013-02-12 05:29:04 UTC

gammaray-1.3.0-2.fc17 has been pushed to the Fedora 17 testing repository.

Comment 9 Fedora Update System 2013-02-20 04:02:39 UTC

gammaray-1.3.0-2.fc18 has been pushed to the Fedora 18 stable repository.

Comment 10 Fedora Update System 2013-02-20 04:05:06 UTC

gammaray-1.3.0-2.fc17 has been pushed to the Fedora 17 stable repository.