Bug 906765
| Summary: | Review Request: mingw-libwebp - MinGW compilation of Library and tools for the WebP format | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paweł Forysiuk <tuxator> |
| Component: | Package Review | Assignee: | Kalev Lember <kalevlember> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | kalevlember, notting, package-review |
| Target Milestone: | --- | Flags: | kalevlember:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | mingw-libwebp-0.2.1-2.fc18 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-04-02 01:31:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Paweł Forysiuk
2013-02-01 12:35:31 UTC
Taking for review. The scratch build failed, can you fix this up so it builds in koji, please? http://koji.fedoraproject.org/koji/taskinfo?taskID=4921458 Sorry for such delay. I had some problems with koji. Updated specs and srpms below. Spec URL: https://dl.dropbox.com/u/2448780/mingw-libwebp.spec SRPM URL: https://dl.dropbox.com/u/2448780/mingw-libwebp-0.2.1-2.fc18.src.rpm Scratch build here http://koji.fedoraproject.org/koji/taskinfo?taskID=5169660 Fedora review of mingw-libwebp-0.2.1-2.fc18.src.rpm 2013-03-25
+ OK
! needs attention
rpmlint output:
$ rpmlint mingw-libwebp-0.2.1-1.fc19.src.rpm \
mingw32-libwebp-0.2.1-1.fc19.noarch.rpm \
mingw64-libwebp-0.2.1-1.fc19.noarch.rpm \
mingw32-libwebp-debuginfo-0.2.1-1.fc19.noarch.rpm \
mingw64-libwebp-debuginfo-0.2.1-1.fc19.noarch.rpm
mingw-libwebp.src: W: spelling-error %description -l en_US WebP -> Web P, Web, Webb
mingw-libwebp.src: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy
mingw-libwebp.src: W: spelling-error %description -l en_US codec -> codex, code, codes
mingw-libwebp.src: W: invalid-url Source0: http://webp.googlecode.com/files/libwebp-0.2.1.tar.gz HTTP Error 404: Not Found
mingw32-libwebp.noarch: W: spelling-error %description -l en_US WebP -> Web P, Web, Webb
mingw32-libwebp.noarch: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy
mingw32-libwebp.noarch: W: spelling-error %description -l en_US codec -> codex, code, codes
mingw64-libwebp.noarch: W: spelling-error %description -l en_US WebP -> Web P, Web, Webb
mingw64-libwebp.noarch: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy
mingw64-libwebp.noarch: W: spelling-error %description -l en_US codec -> codex, code, codes
mingw32-libwebp-debuginfo.noarch: E: debuginfo-without-sources
mingw64-libwebp-debuginfo.noarch: E: debuginfo-without-sources
5 packages and 0 specfiles checked; 2 errors, 10 warnings.
+ The rpmlint errors/warnings are harmless and can be ignored
+ The package is named according to Fedora MinGW packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The stated license is the same as the one for the corresponding
native Fedora package
! No license file, even though it's shipped in the tarball (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
dc9b26f16bd5221414dbab95f13d4453 libwebp-0.2.1.tar.gz
dc9b26f16bd5221414dbab95f13d4453 Download/libwebp-0.2.1.tar.gz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a locale handling
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Not applicable to MinGW packages.
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
+ Packages must not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8
Add the COPYING file and it should be good to go.
Thanks for the input. Files updated according to suggestions. Spec URL: https://dl.dropbox.com/u/2448780/mingw-libwebp.spec SRPM URL: https://dl.dropbox.com/u/2448780/mingw-libwebp-0.2.1-2.fc18.src.rpm Looks good to me. APPROVED New Package SCM Request ======================= Package Name: mingw-libwebp Short Description: MinGW compilation of Library and tools for the WebP format Owners: pfor Branches: f18 f19 Git done (by process-git-requests). |