Bug 906843
Summary: | Review Request: rubygem-qpid_proton - Ruby language bindings for the Qpid Proton messaging framework | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Darryl L. Pierce <dpierce> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | notting, package-review, tross |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-03-08 06:51:18 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Darryl L. Pierce
2013-02-01 16:45:33 UTC
Taking. Well, * Current rawhide qpid_proton is 0.4 and BuildRequires dependency cannot be satisfied. Would you check this? * Also the original gem file cannot be found on rubygems site. (In reply to comment #2) > Well, > * Current rawhide qpid_proton is 0.4 and BuildRequires dependency > cannot be satisfied. Would you check this? > > * Also the original gem file cannot be found on rubygems site. Proton 0.4 was voted on and released this week. I've rebased this package on that release: Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-qpid_proton.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-qpid_proton-0.4-1.fc18.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5067601 For 0.4-1 * Version specific requires for ruby(release) - It seems that ruby(release) (Build)Requires should not have version specific dependency (see Vít's comments: http://lists.fedoraproject.org/pipermail/ruby-sig/2013-February/001259.html ) * Installing native extension - The following line ------------------------------------------------------- mkdir -p %{buildroot}%{gem_extdir_mri}/ mv %{buildroot}%{gem_instdir}/lib/cproton.so \ %{buildroot}%{gem_extdir_mri}/lib ------------------------------------------------------- makes cproton.so _renamed_ to lib (i.e. the file "lib" is created with these lines). * gem install - For gem install, please use %gem_install macro (note that on F-19, %gem_install used different option for documentation generation - on F-18/17, %gem_install also uses --rdoc option) Currently "Installing native extension" item is really blocker. (In reply to comment #4) > For 0.4-1 > > * Version specific requires for ruby(release) > - It seems that ruby(release) (Build)Requires should > not have version specific dependency > (see Vít's comments: > > http://lists.fedoraproject.org/pipermail/ruby-sig/2013-February/001259.html > ) Fixed. > * Installing native extension > - The following line > ------------------------------------------------------- > mkdir -p %{buildroot}%{gem_extdir_mri}/ > mv %{buildroot}%{gem_instdir}/lib/cproton.so \ > %{buildroot}%{gem_extdir_mri}/lib > ------------------------------------------------------- > makes cproton.so _renamed_ to lib (i.e. the > file "lib" is created with these lines). Fixed. The specfile now ensures the directory exists, and then moves the shared library appropriately. > * gem install > - For gem install, please use %gem_install macro > (note that on F-19, %gem_install used different > option for documentation generation - on F-18/17, > %gem_install also uses --rdoc option) > > Currently "Installing native extension" item is really blocker. Done. Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-qpid_proton.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-qpid_proton-0.4-1.1.fc18.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5070299 For 0.4-1.1 * %gem_install usage - As written in /etc/rpm/macros.rubygems: --------------------------------------------------------- # Install gem into appropriate directory. # -n<gem_file> Overrides gem file name for installation. # -d<install_dir> Set installation directory. --------------------------------------------------------- and the default option is ./%{gem_dir}, and %{gem_name}-%{version}.gem for -n option. Note that to change gem_file and install_dir, explitit "-n" and "-d" is needed. For currently, for this package simply "%gem_install" is enough (and actually the following "%{gem_name}-%{version}.gem" is just ignored). Other things are okay. -------------------------------------------------- This package (rubygem-qpid_proton) is APPROVED by mtasaka -------------------------------------------------- Thank you! New Package SCM Request ======================= Package Name: rubygem-qpid_proton Short Description: Ruby language bindings for the Qpid Proton messaging framework Owners: mcpierce Branches: f17 f18 el6 InitialCC: Git done (by process-git-requests). rubygem-qpid_proton-0.4-2.1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-qpid_proton-0.4-2.1.fc18 rubygem-qpid_proton-0.4-2.1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-qpid_proton-0.4-2.1.fc17 rubygem-qpid_proton-0.4-2.1.fc18 has been pushed to the Fedora 18 testing repository. Closing. rubygem-qpid_proton-0.4-2.1.fc17 has been pushed to the Fedora 17 stable repository. rubygem-qpid_proton-0.4-2.1.fc18 has been pushed to the Fedora 18 stable repository. Package Change Request ====================== Package Name: rubygem-qpid_proton New Branches: epel7 Owners: mcpierce Git done (by process-git-requests). |