Bug 906844

Summary:	IllegalArgumentException in JON 3.1.2.GA agent.log during operations with JPP
Product:	[JBoss] JBoss Operations Network	Reporter:	mgottval <mgottval>
Component:	Agent	Assignee:	RHQ Project Maintainer <rhq-maint>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Mike Foley <mfoley>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	JON 3.1.2	CC:	hrupp, mvecera, myarboro, spinder
Target Milestone:	ER01
Target Release:	JON 3.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description mgottval 2013-02-01 16:48:15 UTC

Version-Release number of selected component (if applicable):
JON 3.1.2.GA

I'm getting exception in agent.log during discovery and operations with JPP 6.0.0.ER05:

ERROR [ResourceDiscoveryComponent.invoker.daemon-3] (rhq.modules.plugins.jbossas7.StandaloneASDiscovery)- Discovery of a JBossAS7 Standalone Server Resource failed for process: pid=[9548], name=[/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/bin/java], ppid=[9505].
java.lang.IllegalArgumentException: No product type with product-name 'Portal Platform' is known.
	at org.rhq.modules.plugins.jbossas7.JBossProductType.getValueByProductName(JBossProductType.java:76)
	at org.rhq.modules.plugins.jbossas7.BaseProcessDiscovery$ProductInfo.getFromRemote(BaseProcessDiscovery.java:607)
	at org.rhq.modules.plugins.jbossas7.BaseProcessDiscovery.buildResourceDetails(BaseProcessDiscovery.java:213)
	at org.rhq.modules.plugins.jbossas7.StandaloneASDiscovery.buildResourceDetails(StandaloneASDiscovery.java:84)
	at org.rhq.modules.plugins.jbossas7.BaseProcessDiscovery.discoverResources(BaseProcessDiscovery.java:136)
	at sun.reflect.GeneratedMethodAccessor26.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:616)
	at org.rhq.core.pc.util.DiscoveryComponentProxyFactory$ComponentInvocationThread.call(DiscoveryComponentProxyFactory.java:293)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
	at java.util.concurrent.FutureTask.run(FutureTask.java:166)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
	at java.lang.Thread.run(Thread.java:679)

Comment 2 Simeon Pinder 2013-02-01 23:13:54 UTC

Ok. So I spent some time tracking this issue down and it's a little bit of a mess.

It's definitely a bug, but it looks worse than it actually is.

The short of it is that the AS7 plugin was updated to support JPP on autodiscovery and does so successfully and this is when it pulls the information out of the product.conf file as described by https://docspace.corp.redhat.com/docs/DOC-124664. The bad news is that we forgot to also update the 'Product Name' component to 'Portal Platform'. This means that when the root server is discovered it has all the correct product information, but once the JBossAS7 instance is configured to use the management user that subsequent discovery requests will cause this nasty exception in the log. This is kind of a redundant discovery exception because once you've discovered the root JPP server you won't need to rediscover it for the children resources to be correctly discovered or to interact with the server resource. The ugly part is that the error in the agent logs will continue until patched or fixed in the next release or the following workaround is applied.

#Workaround
The AS7 plugin erroneously looks for the string 'JPP' to be listed from the [JPP install folder]/modules/org/jboss/as/product/jpp/dir/META-INF file as the value for 'JBoss-Product-Release-Name: Portal Platform'. Change 'Portal Platform' to 'JPP' and restart your JPP server. The exception will no longer be listed on discovery. Unsure if change the product name here will have other side effect for routine JPP usage.

Comment 3 Simeon Pinder 2013-02-01 23:25:23 UTC

This is fixed in master with commit: 982fb93fc5e406808

Leaving in current state for correct triage and assessment for applicability to other branches.

Comment 4 Charles Crouch 2013-03-04 22:16:03 UTC

This is fixed in master and should be available in the next jon32 build

Comment 5 mgottval 2013-10-01 08:08:55 UTC

Verified on JON 3.2.ER02 + JPP 6.1.CR03.