Bug 906972
Summary: | ktimezoned doesn't watch for /etc/localtime changes if the file didn't exist at startup time | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Kevin Kofler <kevin> |
Component: | kde-runtime | Assignee: | Than Ngo <than> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | 18 | CC: | dvratil, jgrulich, jreznik, kevin, ltinkl, mbriza, poc, rdieter, rnovacek, smparrish, than |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | 906854 | Environment: | |
Last Closed: | 2013-02-08 16:57:23 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Kevin Kofler
2013-02-02 06:06:34 UTC
I have a possible fix for that too, but I need some sleep now, I'll do builds after sleeping. From bug #906854: Patrick O'Callaghan 2013-02-02 09:29:48 EST > Hmmm, can you please check what time zone is selected in the dialog after > you select your timezone and click Apply, but before you exit the dialog? I > suspect it is jumping back to UTC, which in turn makes it ask you whether to > apply or discard the change which reverts the timezone to UTC (i.e. Discard > is actually what you want then). > > If I'm right and that's what happening, then the problem must be when the > dialog reloads the time information using Dtime::load(). That function uses > KSystemTimeZones::local() to determine the current time zone, somehow that > must be returning wrong or outdated information. Well spotted, that's exactly what is happening. After selecting the new timezone the dialogue box whites out and when it comes back I find UTC is still selected, even though 'date' shows the new timezone. Can you please test this build: http://koji.fedoraproject.org/koji/buildinfo?buildID=381928 ? (If you're testing on a live image, don't forget to also apply the kde-workspace fix from bug #906854.) You probably need to restart your session after updating the package, so that the fixed ktimezoned actually gets started. (In reply to comment #3) > Can you please test this build: > http://koji.fedoraproject.org/koji/buildinfo?buildID=381928 > ? > > (If you're testing on a live image, don't forget to also apply the > kde-workspace fix from bug #906854.) OK, tested and working. The dialogue correctly sets and keeps the new timezone. Thanks Kevin. Patch sent upstream: https://git.reviewboard.kde.org/r/108727/ There is still a (relatively minor) issue which I hadn't noticed earlier. After applying a timezone change and proceeding to exit the dialogue, you still have to confirm Apply or Discard. Selecting Apply simply exits (leaving the change in place), but Discard does the same thing, i.e. it doesn't revert the change. IIRC in other Settings dialogues hitting Apply before exiting means you don't have to reconfirm, so the question doesn't arise. At the same time, making a change and attempting to exit without hitting Apply will bring up the confirmation dialogue with the expected semantics. IOW the Time/Date is inconsistent with this behaviour. kde-runtime-4.9.5-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/kde-runtime-4.9.5-2.fc18 Package kde-runtime-4.9.5-2.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing kde-runtime-4.9.5-2.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-1932/kde-runtime-4.9.5-2.fc18 then log in and leave karma (feedback). (In reply to comment #7) > There is still a (relatively minor) issue which I hadn't noticed earlier. > After applying a timezone change and proceeding to exit the dialogue, you > still have to confirm Apply or Discard. Selecting Apply simply exits > (leaving the change in place), but Discard does the same thing, i.e. it > doesn't revert the change. IIRC in other Settings dialogues hitting Apply > before exiting means you don't have to reconfirm, so the question doesn't > arise. At the same time, making a change and attempting to exit without > hitting Apply will bring up the confirmation dialogue with the expected > semantics. IOW the Time/Date is inconsistent with this behaviour. These comments still apply as of 4.9.5-7 (F18). IMHO the easiest fix is to disable the confirmation when the user has already hit Apply in the settings dialogue. This would be consistent with other settings dialogues. kde-runtime-4.9.5-2.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. |