Bug 907041

Summary:	"Install Updates & Restart" displayed when no new updates are available
Product:	[Fedora] Fedora	Reporter:	Michael Catanzaro <mcatanzaro+wrong-account-do-not-cc>
Component:	PackageKit	Assignee:	Richard Hughes <rhughes>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	18	CC:	admiller, cra, fmuellner, jonathan, mark.harfouche, otaylor, rdieter, rhughes, rvitale, samkraju, smparrish, walters
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-12-10 17:32:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michael Catanzaro 2013-02-02 20:39:31 UTC

Description of problem: "Install Updates & Restart" button triggers the systemd offline update process but sometimes does not update any packages (as revealed by Software Log in gnome-packagekit). The button remains present after a restart, inviting the user to enter an infinite series of restart/updates that never update anything. No error message is displayed at any point.*

* Generally. I got a "no updates installed" error message once about a week ago, but it's happened several times since with no such warning.

Version-Release number of selected component (if applicable): gnome-shell-3.6.2-6.fc18

How reproducible: Has happened several times since installing Fedora 18.

Steps to Reproduce:
1. Wait until "important updates available" notification appears, prompting for an online update through gpk-update-viewer
2. Install the online updates as prompted
3. "Install Updates & Restart" button remains on the shell menu
4. Click the button, presumably to finish the update process

Actual results: Button remains present on restart. Checking Software Log in gnome-packagekit reveals that the offline update didn't actually update anything. Click on the button again to trigger another restart/update. Button remains present on restart and nothing was updated. Click again... the menu item remains, prompting the user to restart and update nothing, until the user manually triggers another check for updates by going to System Settings -> Details

Expected results: This menu button should never be present unless there are actually updates available to install.

Additional info: Note that I'm guessing a bit as to what's going on here as I'm not familiar with the update mechanisms -- maybe it's not a shell issue and something deeper is wrong -- but I suspect we're just bad at deciding when to display the offline updates options. Installing online updates should trigger whatever action decides if the shell should display this option, and it should never display after an offline update. (If logs would be helpful please let me know which ones. :-)

Comment 1 Florian Müllner 2013-02-07 14:47:50 UTC

(In reply to comment #0)
> I'm not familiar with the update mechanisms -- maybe it's not a shell issue
> and something deeper is wrong -- but I suspect we're just bad at deciding
> when to display the offline updates options.


It probably is a problem down the stack. From the shell side, the mechanism is fairly simple - the "Install Updates & Reboot" item is shown iff the file /var/lib/PackageKit/prepared-update exists. So unless there is a bug with regard to monitoring that file, the PackageKit daemon fails to remove the file (probably after updates have been applied "online" via yum).

If it happens again, can you confirm that /var/lib/PackageKit/prepared-update is present and reassign to PackageKit if that's the case?

Comment 2 Michael Catanzaro 2013-02-12 23:23:40 UTC

Today I installed updates as prompted by the "Important updates are available" notification; i.e. I installed the "online" updates using gpk-update-viewer. "Install Updates & Restart" was visible on the shell menu after I noticed the notification. After installing updates, I was prompted to log out and log back in (I don't think I had to do this last time but I might be wrong). Install Updates & Restart is still visible. /var/lib/PackageKit/prepared-update still exists and contains a list of all the files that were just updated:

[michael@victory-road ~]$ cat /var/lib/PackageKit/prepared-update 
rpm;4.10.3.1-1.fc18;x86_64;updates
qemu-common;2:1.2.2-6.fc18;x86_64;updates
libsmbclient;2:4.0.2-1.fc18;x86_64;updates
selinux-policy-targeted;3.11.1-76.fc18;noarch;updates
samba-common;2:4.0.2-1.fc18;x86_64;updates
glusterfs;3.3.1-9.fc18;x86_64;updates
rpm-python;4.10.3.1-1.fc18;x86_64;updates
iproute;3.6.0-6.fc18;x86_64;updates
rpm-libs;4.10.3.1-1.fc18;x86_64;updates
qemu-img;2:1.2.2-6.fc18;x86_64;updates
selinux-policy;3.11.1-76.fc18;noarch;updates
qemu-kvm;2:1.2.2-6.fc18;x86_64;updates
nss-sysinit;3.14.2-2.fc18;x86_64;updates
nss-tools;3.14.2-2.fc18;x86_64;updates
selinux-policy-doc;3.11.1-76.fc18;noarch;updates
xorg-x11-drv-synaptics;1.6.3-1.fc18;x86_64;updates
rpm-build-libs;4.10.3.1-1.fc18;x86_64;updates
libsss_idmap;1.9.4-3.fc18;x86_64;updates
pytalloc;2.0.8-1.fc18;x86_64;updates
dnsmasq;2.65-4.fc18;x86_64;updates
selinux-policy-devel;3.11.1-76.fc18;noarch;updates
qemu-system-x86;2:1.2.2-6.fc18;x86_64;updates
nspr;4.9.5-1.fc18;x86_64;updates
nss-util;3.14.2-2.fc18;x86_64;updates
sssd;1.9.4-3.fc18;x86_64;updates
libldb;1.1.15-2.fc18;x86_64;updates
nss-softokn-freebl;3.14.2-3.fc18;x86_64;updates
sssd-client;1.9.4-3.fc18;x86_64;updates
libtalloc;2.0.8-1.fc18;x86_64;updates
nss;3.14.2-2.fc18;x86_64;updates
graphite2;1.1.1-4.fc18;x86_64;updates
glusterfs-fuse;3.3.1-9.fc18;x86_64;updates
nss-softokn;3.14.2-3.fc18;x86_64;updates
libwbclient;2:4.0.2-1.fc18;x86_64;updates
libipa_hbac;1.9.4-3.fc18;x86_64;updates
libtdb;1.2.11-1.fc18;x86_64;updates
samba-libs;2:4.0.2-1.fc18;x86_64;updates
libcacard;2:1.2.2-6.fc18;x86_64;updates
telepathy-gabble;0.16.4-3.fc18;x86_64;updates

I'm about to click "Install Updates & Restart" to see what happens, but I suspect it'll be another "update nothing".

Comment 3 Michael Catanzaro 2013-02-12 23:38:12 UTC

Yup, "Install Updates & Restart" is still here and nothing was updated. It goes away when I manually check for updates, and then /var/lib/PackageKit/prepared-update is gone. (I did forget to check if it was there after restarting and before running "check for updates".) So this is probably not a shell problem. (Note that I don't have permission to reassign this bug to another component.)

I recently did an update in the same manner on openSUSE 12.3 RC1 where "Install Updates & Restart" disappeared after gpk-update-viewer finished its work, so it's possible this is not an issue for other distros.

Comment 4 Florian Müllner 2013-02-14 08:20:18 UTC

OK, so this is indeed a problem of PackageKit not removing the file after doing the update "online".

Comment 5 Michael Catanzaro 2013-02-18 23:41:20 UTC

Maybe this commit is a fix?

http://gitorious.org/packagekit/packagekit/commit/c8646c384392106ff5e64ae5def957fb71d866b9

Comment 6 Michael Catanzaro 2013-06-05 02:59:31 UTC

I think this was fixed with this week's PackageKit update.

Comment 7 Richard Hughes 2013-12-10 17:32:32 UTC

(In reply to Michael Catanzaro from comment #6)
> I think this was fixed with this week's PackageKit update.

Agreed.