Bug 907506

Summary: [User Portal] Change CD - selecting blank line gets Change CD dialog stuck
Product: Red Hat Enterprise Virtualization Manager Reporter: Jiri Belka <jbelka>
Component: ovirt-engineAssignee: Martin Betak <mbetak>
Status: CLOSED CURRENTRELEASE QA Contact: Jiri Belka <jbelka>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.2.0CC: bsettle, lpeer, mbetak, michal.skrivanek, oourfali, pstehlik, rbalakri, Rhev-m-bugs, sherold, srevivo
Target Milestone: ovirt-3.6.0-rcFlags: sherold: Triaged+
Target Release: 3.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-3-6-0-2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-20 01:32:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1134787    
Bug Blocks:    
Attachments:
Description Flags
stucked change cd dialog
none
engine.log from is1 none

Description Jiri Belka 2013-02-04 15:19:44 UTC
Created attachment 692809 [details]
stucked change cd dialog

Description of problem:
When there's inactive ISO domain, there are 2 entries in Change CD dialog in User Portal - blank line + 'No CDs'.

1. selecting blank line gets Change CD dialog stucked
2. why is there this blank line anyway?

2013-02-04 16:17:36,858 INFO  [org.ovirt.engine.core.vdsbroker.irsbroker.IsoPrefixVDSCommand] (ajp-/127.0.0.1:8702-7) [6a14eaba] START, IsoPrefixVDSCommand( storagePoolId = a05c6f22-2a40-4f39-a2a8-aa91b539b217, ignoreFailoverLimit = false, compatabilityVersion = null), log id: 56748a5a
2013-02-04 16:17:36,858 INFO  [org.ovirt.engine.core.vdsbroker.irsbroker.IsoPrefixVDSCommand] (ajp-/127.0.0.1:8702-7) [6a14eaba] FINISH, IsoPrefixVDSCommand, return: /rhev/data-center/a05c6f22-2a40-4f39-a2a8-aa91b539b217/a7e5f59c-2877-475b-8afc-f760ba63defb/images/11111111-1111-1111-1111-111111111111, log id: 56748a5a
2013-02-04 16:17:36,938 WARN  [org.ovirt.engine.core.bll.ChangeDiskCommand] (ajp-/127.0.0.1:8702-7) [6a14eaba] CanDoAction of action ChangeDisk failed. Reasons:VAR__ACTION__CHANGE_CD,VM_CANNOT_WITHOUT_ACTIVE_STORAGE_DOMAIN_ISO

nothing about blank line in logs...

Version-Release number of selected component (if applicable):
sf5

How reproducible:
100%

Steps to Reproduce:
1. have an inactive cd domain
2. have a running VM
3. click Change CD in User Portal, check the list and select blank line
  
Actual results:


Expected results:


Additional info:

Comment 1 Martin Betak 2013-03-13 10:21:46 UTC
merged in u/s as 590c9c3b0018dc721619dcf248d0388e3e55eb8c

Comment 2 Jiri Belka 2013-05-31 09:54:24 UTC
Looks odd. While having inactive (maintenance) iso domain, I can see isos in Change CD dialog, interesting. After selecting one iso I get:

Error while executing action:

jb-rh6-x64-2:

    Cannot Change CD without active ISO domain.

Why I can see isos if domain is not active. It is not mounted on host!

[root@dell-r210ii-04 ~]# mount | grep 'type nfs'
10.34.63.204:/mnt/export/nfs/export on /rhev/data-center/mnt/10.34.63.204:_mnt_export_nfs_export type nfs (rw,soft,nosharecache,timeo=600,retrans=6,nfsvers=3,addr=10.34.63.204)
10.34.63.199:/jb02 on /rhev/data-center/mnt/10.34.63.199:_jb02 type nfs (rw,soft,nosharecache,timeo=600,retrans=6,nfsvers=3,addr=10.34.63.199)

Comment 3 Jiri Belka 2013-05-31 09:55:08 UTC
Created attachment 755221 [details]
engine.log from is1

Comment 4 Michal Skrivanek 2013-09-13 11:15:12 UTC
may need to wait or the new foreign menu implementation...

Comment 6 Michal Skrivanek 2014-07-24 11:44:01 UTC
deferring till the foreign menu support is decided

Comment 8 Michal Skrivanek 2015-04-12 09:51:50 UTC
implemented using REST API from virt-viewer. 
Works only with "native" .vv invocation

Comment 9 Michal Skrivanek 2015-04-12 10:09:03 UTC
and only in user portal. 
For details please see the original virt-viewer rest api bug 975730

Comment 11 Jiri Belka 2015-06-18 11:30:12 UTC
OK, back to roots - this BZ used to be about 'Change CD' dialog in User Portal, repeating again - in User Portal. Thus it had nothing to do with SPICE client at all.

Anyway, with recent version when ISO domain is inactive, there's only 'Eject' item in the list of the 'Change CD' dialog. No blank line, no stucked web app.
Also an issue mentioned in #2 is not the case anymore (just 'Eject' as mentioned above).

I'm changing subject back to original one as oVirt gerrit ID points to User Portal code change and to un-confuse this BZ for future.

ovirt-engine-userportal-3.6.0-0.0.master.20150519172219.git9a2e2b3.el6.noarch

Comment 12 Jiri Belka 2015-06-23 07:57:42 UTC
How this can be RFE is really mystery to me.

Comment 13 Jiri Belka 2015-06-23 13:15:36 UTC
Please "remove" this BZ from 3.6 RFEs, see #11 for details. Thx!

Comment 14 Oved Ourfali 2015-06-23 13:26:37 UTC
(In reply to Jiri Belka from comment #13)
> Please "remove" this BZ from 3.6 RFEs, see #11 for details. Thx!

This is a virt bug.
Michal?

Comment 15 Michal Skrivanek 2015-06-23 14:25:33 UTC
I have no problem with that
SPICE REST foreign menu has been implemented in upstream, I don't mind if it's not tracked