Bug 907513
| Summary: | Review Request: clearlooks-phenix-theme - Clearlooks-Phenix gtk theme | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard Marko <rmarko> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jberan, lkundrak, notting, package-review, rmarko |
| Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-04-03 04:26:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Richard Marko
2013-02-04 15:28:25 UTC
* Package name correct * Soruce tarball creation properly commented on * License correct and allowed in fedora * Spec file clean and legible * Builds fine in mock 1.) Newer version (3.0.15) is available 2.) Description is not accurate You speak of gtk3 theme, but ship theme for metacity and gtk2. Are those needed at all? 3.) Requires/provides might need tweaking: see below Would you mind splitting the themes into subpackages as is done for other theme packages (e.g. zukini), so that you'll have: clearlooks-phenix-gtk2-theme clearlooks-phenix-gtk3-theme clearlooks-phenix-xfwm4-theme clearlooks-phenix-metacity-theme clearlooks-phenix-openbox-theme clearlooks-phenix-common You'll be able to fix up the dependency chain then (e.g. not requiring clearlooks gtk2 engine when user only needs gtk3). Also, you'd be able to add missing Requires (of metacity or gtk+ itself) while not being afraid of dragging in unnecessary packages. Done. Spec URL: http://rmarko.fedorapeople.org/packages/clearlooks-phenix.spec SRPM URL: http://rmarko.fedorapeople.org/packages/clearlooks-phenix-3.0.15-1.fc18.src.rpm ♥ Seems sane now, may God shower you with grace and blessings!
=== clearlooks-phenix-common-3.0.15-1.fc18.noarch ===
Requires:
Provides:
clearlooks-phenix-common = 3.0.15-1.fc18
=== clearlooks-phenix-gtk2-theme-3.0.15-1.fc18.noarch ===
Requires:
clearlooks-phenix-common = 3.0.15-1.fc18
gtk2-engines
Provides:
clearlooks-phenix-gtk2-theme = 3.0.15-1.fc18
=== clearlooks-phenix-gtk3-theme-3.0.15-1.fc18.noarch ===
Requires:
clearlooks-phenix-common = 3.0.15-1.fc18
gtk3
Provides:
clearlooks-phenix-gtk3-theme = 3.0.15-1.fc18
=== clearlooks-phenix-metacity-theme-3.0.15-1.fc18.noarch ===
Requires:
clearlooks-phenix-common = 3.0.15-1.fc18
metacity
Provides:
clearlooks-phenix-metacity-theme = 3.0.15-1.fc18
=== clearlooks-phenix-openbox-theme-3.0.15-1.fc18.noarch ===
Requires:
clearlooks-phenix-common = 3.0.15-1.fc18
openbox
Provides:
clearlooks-phenix-openbox-theme = 3.0.15-1.fc18
=== clearlooks-phenix-xfwm4-theme-3.0.15-1.fc18.noarch ===
Requires:
clearlooks-phenix-common = 3.0.15-1.fc18
xfwm4
Provides:
clearlooks-phenix-xfwm4-theme = 3.0.15-1.fc18
APPROVED
New Package SCM Request ======================= Package Name: clearlooks-phenix-theme Short Description: Clearlooks-Phenix is a GTK+ 3 port of Clearlooks, the default theme for GNOME 2. Owners: rmarko Branches: f17 f18 InitialCC: Git done (by process-git-requests). I'm sorry but the Package name in comment #4 was wrong. It should be Package Name: clearlooks-phenix as it was renamed during the review. Provide a request with the correct name, and then follow the package EOL procedure for the package with the incorrect name. New Package SCM Request ======================= Package Name: clearlooks-phenix Short Description: Clearlooks-Phenix is a GTK+ 3 port of Clearlooks, the default theme for GNOME 2. Owners: rmarko Branches: f17 f18 InitialCC: Git done (by process-git-requests). clearlooks-phenix-3.0.15-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/clearlooks-phenix-3.0.15-1.fc17 clearlooks-phenix-3.0.15-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/clearlooks-phenix-3.0.15-1.fc18 clearlooks-phenix-3.0.15-1.fc18 has been pushed to the Fedora 18 testing repository. clearlooks-phenix-3.0.15-1.fc18 has been pushed to the Fedora 18 stable repository. clearlooks-phenix-3.0.15-1.fc17 has been pushed to the Fedora 17 stable repository. |