Bug 907931

Summary: [RFE] ovirt-shell vnc console does not work with tigervnc client
Product: [Retired] oVirt Reporter: Sander Hoentjen <sander>
Component: ovirt-engine-cliAssignee: Michael Pasternak <mpastern>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.2CC: acathrow, bazulay, iheim, jkt, juan.hernandez, mpastern
Target Milestone: ---Keywords: FutureFeature
Target Release: 3.3.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of:
: 908016 909365 (view as bug list) Environment:
Last Closed: 2013-12-02 07:53:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 908016, 909365    
Attachments:
Description Flags
patch that solves the issue for me none

Description Sander Hoentjen 2013-02-05 14:59:19 UTC 
Description of problem:
the console command runs vncviewer <host>:<port> -passwdInput, but -passwdInput is not supported with tigervnc

Version-Release number of selected component (if applicable):
ovirt-engine-cli-3.2.0.9-1.fc18.noarch

How reproducible:
Always

Steps to Reproduce:
1. connect with ovirt-shell 
2. console <vmname> where vm has display set as VNC
  
Actual results:
no console is displayed

Expected results:
console is displayed

Additional info:
command run now is:
echo <ticket> | <host>::<port> -passwdInput

what would work is:
echo <ticket> | vncpasswd -f | vncviewer <host>::<port> -passwordFile /dev/stdin

relevant code is in /usr/lib/python2.7/site-packages/ovirtcli/platform/posix/vnc.py
Comment 1 Sander Hoentjen 2013-02-06 20:21:35 UTC 
This is because in F18 the patch was dropped to add -passwdInput to vncviewer:
See: http://koji.fedoraproject.org/koji/buildinfo?buildID=365068
"""
* Fri Aug 17 2012 Adam Tkac <atkac redhat com> 1.2.80-0.1.20120905svn4996
- update to 1.2.80
- remove deprecated patches
 - tigervnc-102434.patch
 - tigervnc-viewer-reparent.patch
 - tigervnc11-java7.patch
- patches merged
 - tigervnc11-xorg111.patch
 - tigervnc11-xorg112.patch
"""
tigervnc-102434.patch is the patch that implemented -passwdInput:
http://pkgs.fedoraproject.org/cgit/tigervnc.git/commit/?id=5e164de8bf7b74db5b65e29123dd63b6fc6fd1fc
Comment 2 Sander Hoentjen 2013-02-06 20:23:06 UTC 
Created attachment 694128 [details]
patch that solves the issue for me
Comment 3 Juan Hernández 2013-02-08 09:03:52 UTC 
Sander, I think that this patch is worh adding upstream, would you consider pushing it to the upstream gerrit? Meanwhile I will apply it to the package.
Comment 4 Sander Hoentjen 2013-02-08 09:57:38 UTC 
Juan: http://gerrit.ovirt.org/#/c/11857/
Comment 8 Itamar Heim 2013-12-01 10:22:27 UTC 
i see patch was merged a while back - should this be closed current release by now?