Bug 909012 (CVE-2013-0270)

Summary: CVE-2013-0270 OpenStack Keystone: Large HTTP request DoS
Product: [Other] Security Response Reporter: Kurt Seifried <kseifried>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED ERRATA QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: apevec, ayoung, cpelland, dprince, jlieskov, markmc, rbryant, rhos-maint
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-04-04 20:46:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 908973, 909013    
Bug Blocks: 909025    

Description Kurt Seifried 2013-02-08 03:32:09 UTC
Dan Prince (dprince) reports:

When long tenant_name is sent few times when requesting token, responsiveness 
of service decreases until finally it requests ends with MemoryError.

keystoneclient.exceptions.AuthorizationFailure: Authorization Failed: Unable 
to communicate with identity service: Traceback ... MemoryError
Includes whole traceback.

Memory on keystone host is used up keystone-all process.
Also during processing of the request CPU utilization raises for a long time 
(when and after the first MemoryError state was reached) - like for more than 
10 seconds keystone-all can take whole cpu.


Version-Release number of selected component (if applicable):
Name        : openstack-keystone
Arch        : noarch
Version     : 2012.2.1
Release     : 3.el6ost


How reproducible:
Use something similiar to following python example few times (5 times with 
"len(tenant) == 195000000" for keystone host inside VM with 4GB of RAM)

Actual results:
For first few tries service correctly responds with:
(HTTP 400): Authorization Failed: Request attribute tenantName must be less 
than or equal to 64. The server could not comply with the request because the 
attribute size is invalid (too large). The client is assumed to be in error.

Later with:
(HTTP 500): Authorization Failed: Unable to communicate with identity service: 
Traceback (most recent call last):
  ... whole backtrace here
MemoryError

Most memory of keystone host is used by keystone-all process.


Expected results:
The first 400 error mentioning that attribute is too big for all request (not 
only first few). And not such a big impact on memory of host.


Additional info:
Similiar to bug #906178 and so also to related upstream bug 
https://bugs.launchpad.net/keystone/+bug/1098307 where they mentioned 
preparation of general check/defense for too big requests.

Comment 2 Kurt Seifried 2013-02-08 04:50:30 UTC
This is public: https://bugs.launchpad.net/keystone/+bug/1099025

Comment 3 Jan Lieskovsky 2013-02-11 11:20:47 UTC
Relevant upstream patch against the master branch:
  https://github.com/openstack/keystone/commit/7691276b869a86c2b75631d5bede9f61e030d9d8

Comment 4 Dan Prince 2013-02-12 18:14:48 UTC
Kurt: The pipeline change you link above would fix this... but is sort of a new features. I think this commit (already on Folsom stable) is more backportable:

https://github.com/openstack/keystone/commit/82c87e5638ebaf9f166a9b07a0155291276d6fdc

Comment 5 Alan Pevec 2013-02-12 18:19:55 UTC
(In reply to comment #4)
> https://github.com/openstack/keystone/commit/
> 82c87e5638ebaf9f166a9b07a0155291276d6fdc

And this is in openstack-keystone-2012.2.1-3.el6ost just published.

Comment 7 Alan Pevec 2013-03-04 20:16:25 UTC
(In reply to comment #3)
> Relevant upstream patch against the master branch:
>  
> https://github.com/openstack/keystone/commit/
> 7691276b869a86c2b75631d5bede9f61e030d9d8

This was proposed for stable/folsom but did not pass review:
https://review.openstack.org/#/c/22661/

Comment 11 Murray McAllister 2013-03-27 05:57:23 UTC
Acknowledgements:

This issue was discovered by Dan Prince of Red Hat.

Comment 12 errata-xmlrpc 2013-04-04 20:22:50 UTC
This issue has been addressed in following products:

  OpenStack Folsom for RHEL 6

Via RHSA-2013:0708 https://rhn.redhat.com/errata/RHSA-2013-0708.html