Bug 909671

Following remarks of Remi in #fedora-devel-fr (thanks to him):

Spec URL: http://fantom.fedorapeople.org/libexif-gtk.spec
SRPM URL: http://fantom.fedorapeople.org/libexif-gtk-0.3.6-2.20130210cvs.fc18.src.rpm


This is the diff:

--- ../SPECS/libexif-gtk.spec.old	2013-02-10 10:54:12.000000000 +0100
+++ ../SPECS/libexif-gtk.spec	2013-02-12 05:57:12.466114620 +0100
@@ -4,11 +4,11 @@
 
 Name:           libexif-gtk
 Version:        0.3.6
-Release:        1.%{snapver}%{?dist}
+Release:        2.%{snapver}%{?dist}
 Summary:        Library to display EXIF tags in GTK programs
 Summary(fr):    Bibliothèque pour l'affichage des données EXIF dans les programmes en GTK
 
-License:        GPLv2
+License:        LGPLv2+
 URL:            http://libexif.sourceforge.net/
 
 
@@ -39,6 +39,12 @@ des données EXIF dans les programmes en
 Summary:       Files needed for building applications with libexif-gtk
 Summary(fr):   Fichiers nécéssaires pour construire des applications avec libexif-gtk
 
+Requires:      %{name}%{?_isa} = %{version}-%{release}
+Requires:      pkgconfig
+Requires:      libexif-devel%{?_isa}
+Requires:      gtk2-devel%{?_isa}
+
+
 %description devel
 The libexif-gtk-devel package includes header files and libraries
 necessary for developing programs which use the libexif-gtk library.
@@ -67,6 +73,10 @@ rm -f %{buildroot}%{_libdir}/%{name}.la
 
 
 
+%check
+make check
+
+
 %post -p /sbin/ldconfig
 
 %postun -p /sbin/ldconfig
@@ -85,5 +95,10 @@ rm -f %{buildroot}%{_libdir}/%{name}.la
 
 
 %changelog
+* Tue Feb 12 2013 Matthieu Saulnier <fantom> - 0.3.6-2.20130210cvs
+- Fix license tag
+- Add missing requires tags in devel subpackage
+- Add test suite in %%check section
+
 * Sun Feb 10 2013 Matthieu Saulnier <fantom> - 0.3.6-1.20130210cvs
 - Initial release

Created attachment 696433 [details]
review.txt

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 909671

==== ISSUES ====

[!] (with incorrect FSF address)
        Please this upstream, and add link to bug report

[!]: Package is named according to the Package Naming Guidelines.
        Sources refers as 0.3.6, but as this version is not yet
        released, this is a pre version
        Release: 0.2.%{snapver}%{?dist}

[!]: Requires correct, justified where necessary.
        Drop Requires: pkgconfig

[!]: rpmlint
        Drop empty AUTHORS file

        $ rpmlint -I unused-direct-shlib-dependency
        unused-direct-shlib-dependency:
        The binary contains unused direct shared library dependencies.  This may
        indicate gratuitously bloated linkage; check that the binary has been linked
        with the intended shared libraries only.


=====

According to README you can build with gtk2 OR gtk3.

I think is will be really better to build both libraries: libexif-gtk.so AND libexif-gtk3.so (probably with a new subpackage for gtk3-libs)

Hello, sorry for the latence

(In reply to comment #3)
> ==== ISSUES ====
> 
> [!] (with incorrect FSF address)
>         Please this upstream, and add link to bug report
Reported on libexif devel ML:
  http://sourceforge.net/mailarchive/forum.php?thread_name=1364077038.9112.10.camel%40localhost&forum_name=libexif-devel

> [!]: Package is named according to the Package Naming Guidelines.
>         Sources refers as 0.3.6, but as this version is not yet
>         released, this is a pre version
>         Release: 0.2.%{snapver}%{?dist}
Fixed

> [!]: Requires correct, justified where necessary.
>         Drop Requires: pkgconfig
Dropped

> [!]: rpmlint
>         Drop empty AUTHORS file
> 
>         $ rpmlint -I unused-direct-shlib-dependency
>         unused-direct-shlib-dependency:
>         The binary contains unused direct shared library dependencies.  This
> may
>         indicate gratuitously bloated linkage; check that the binary has
> been linked
>         with the intended shared libraries only.
I hope it is fixed, see %%changelog

> =====
> 
> According to README you can build with gtk2 OR gtk3.
> 
> I think is will be really better to build both libraries: libexif-gtk.so AND
> libexif-gtk3.so (probably with a new subpackage for gtk3-libs)
Done

New SPEC: http://fantom.fedorapeople.org/libexif-gtk.spec
New SRPM: http://fantom.fedorapeople.org/libexif-gtk-0.4.1-0.1.20130323cvs.fc20.src.rpm

%changelog
* Mon Apr 15 2013 Matthieu Saulnier <fantom> - 0.4.1-0.2.20130415cvs
- New upstream snapshot
- Rename Main package as "libexif-gtk3" (old name was "libexif-gtk")
- Rename first subpackage as "libexif-gtk3-devel" (old name was "libexif-gtk-devel)
- Rename second subpackage as "libexif-gtk2" (old name was "libexif-gtk-gtk3-libs")
- Rename third subpackage as "libexif-gtk2-devel" (old name was "libexif-gtk-gtk3-devel")
- Add %%{upname} macro to preserve some upstream paths

New SPEC:http://fantom.fedorapeople.org/libexif-gtk3.spec
New SRPM: http://fantom.fedorapeople.org/libexif-gtk3-0.4.1-0.2.20130415cvs.fc19.src.rpm

Created attachment 736256 [details]
review.txt

Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 909671

Created attachment 736257 [details]
review.txt

Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 909671

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5257399

SHOULD:

[!]: The spec file handles locales properly.

	As both packages share the same locale files,
	no need to run find_lang twice

[!]: %check is present and all tests pass.

	Make check doesn't run anything
	%check Can be removed

COULD:

[!]: Latest version is packaged.

	At one time, I think it will be great to 
	build official version (0.4.0) instead of snaphosts.

Perhaps, Changelog and README files can be moved to -devel.


No blocker.

=== APPROVED ===

Thanks for the review

New Package SCM Request
=======================
Package Name: libexif-gtk3
Short Description: Library to display EXIF tags in GTK3 programs
Owners: fantom
Branches: f19
InitialCC:

Git done (by process-git-requests).

libexif-gtk3-0.4.1-0.2.20130415cvs.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/libexif-gtk3-0.4.1-0.2.20130415cvs.fc19

libexif-gtk3-0.4.1-0.2.20130415cvs.fc19 has been pushed to the Fedora 19 testing repository.

libexif-gtk3-0.4.1-0.2.20130415cvs.fc19 has been pushed to the Fedora 19 stable repository.