Bug 909678

Summary: Fail to sync network when there is two networks on BOND interface and trying syncing only one network
Product: Red Hat Enterprise Virtualization Manager Reporter: Meni Yakove <myakove>
Component: ovirt-engineAssignee: lpeer <lpeer>
Status: CLOSED CURRENTRELEASE QA Contact: Meni Yakove <myakove>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.2.0CC: acathrow, bazulay, danken, dyasny, iheim, lpeer, masayag, mkolesni, Rhev-m-bugs, sgrinber, yeylon, ykaul
Target Milestone: ---   
Target Release: 3.2.0   
Hardware: x86_64   
OS: All   
Whiteboard: network
Fixed In Version: sf10 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 922807    
Attachments:
Description Flags
vdsm.log
none
engine.log none

Description Meni Yakove 2013-02-10 11:31:56 UTC
Created attachment 695714 [details]
vdsm.log

Description of problem:
When trying to sync network on BOND that have two networks attached to it and only syncing one of the networks the operation fails.

Version-Release number of selected component (if applicable):
vdsm-4.10.2-7.0.el6ev.x86_64
rhevm-3.2.0-7.el6ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. On the DC with the host create two vlan networks 'vlan162 and vlan 163'.
2. Create bond and attache 'vlan162 and vlan 163' networks to the bond using SetupNetwork.
3. On the second DC create new bridgless (nonvm, without vlan) network 'vlan163'
4. Move the host to the second DC.
5.  Open SetupNetwork and sync only 'vlan163' network on the bond
  
Actual results:
sync operation fails

Expected results:
network should be synced

Additional info:

MainProcess|Thread-160785::ERROR::2013-02-11 01:11:26,910::configNetwork::1400::setupNetworks::(setupNetworks) (23, "unknown nic: 'bond1'")
Traceback (most recent call last):
  File "/usr/share/vdsm/configNetwork.py", line 1382, in setupNetworks
    implicitBonding=True, **d)
  File "/usr/share/vdsm/configNetwork.py", line 902, in addNetwork
    bridged=bridged, **options)
  File "/usr/share/vdsm/configNetwork.py", line 850, in _addNetworkValidation
    raise ConfigNetworkError(ne.ERR_BAD_NIC, "unknown nic: %r" % nic)
ConfigNetworkError: (23, "unknown nic: 'bond1'")
MainProcess|Thread-160785::ERROR::2013-02-11 01:11:26,918::supervdsmServer::81::SuperVdsm.ServerCallback::(wrapper) Error in setupNetworks
Traceback (most recent call last):
  File "/usr/share/vdsm/supervdsmServer.py", line 79, in wrapper
    return func(*args, **kwargs)
  File "/usr/share/vdsm/supervdsmServer.py", line 178, in setupNetworks
    return configNetwork.setupNetworks(networks, bondings, **options)
  File "/usr/share/vdsm/configNetwork.py", line 1382, in setupNetworks
    implicitBonding=True, **d)
  File "/usr/share/vdsm/configNetwork.py", line 902, in addNetwork
    bridged=bridged, **options)
  File "/usr/share/vdsm/configNetwork.py", line 850, in _addNetworkValidation
    raise ConfigNetworkError(ne.ERR_BAD_NIC, "unknown nic: %r" % nic)
ConfigNetworkError: (23, "unknown nic: 'bond1'")
Thread-160785::ERROR::2013-02-11 01:11:26,918::API::1214::vds::(setupNetworks) unknown nic: 'bond1'
Traceback (most recent call last):
  File "/usr/share/vdsm/API.py", line 1212, in setupNetworks
    supervdsm.getProxy().setupNetworks(networks, bondings, options)
  File "/usr/share/vdsm/supervdsm.py", line 76, in __call__
    return callMethod()
  File "/usr/share/vdsm/supervdsm.py", line 67, in <lambda>
    **kwargs)
  File "<string>", line 2, in setupNetworks
  File "/usr/lib64/python2.6/multiprocessing/managers.py", line 740, in _callmethod
    raise convert_to_error(kind, result)
ConfigNetworkError: (23, "unknown nic: 'bond1'")
Thread-160785::DEBUG::2013-02-11 01:11:26,919::BindingXMLRPC::920::vds::(wrapper) return setupNetworks with {'status': {'message': "unknown nic: 'bond1'", 'code': 23}

Comment 1 Meni Yakove 2013-02-10 11:35:44 UTC
Created attachment 695715 [details]
engine.log

Comment 3 Dan Kenigsberg 2013-02-12 09:15:22 UTC
The culprit is seen here

Thread-160744::DEBUG::2013-02-11 01:06:04,439::BindingXMLRPC::913::vds::(wrapper) client [10.35.70.107]::call setupNetworks with ({'all': {'nic': 'bond1', 'bridged': 'false'}}, {}, {'connectivityCheck': 'true', 'connectivityTimeout': 120}) {}

where "bond1" is considered as a nic (which it is not). Engine should send a proper definition of the "all" network.

Comment 5 Meni Yakove 2013-03-11 14:08:51 UTC
Verified on vdsm-4.10.2-11.0.el6ev.x86_64

Comment 7 Itamar Heim 2013-06-11 09:06:00 UTC
3.2 has been released

Comment 8 Itamar Heim 2013-06-11 09:06:00 UTC
3.2 has been released

Comment 9 Itamar Heim 2013-06-11 09:06:10 UTC
3.2 has been released

Comment 10 Itamar Heim 2013-06-11 09:06:12 UTC
3.2 has been released

Comment 11 Itamar Heim 2013-06-11 09:34:51 UTC
3.2 has been released