Bug 909767

Summary: libxml2 rpm fails to build with --nocheck flag
Product: [Fedora] Fedora Reporter: Mark Salter <msalter>
Component: libxml2Assignee: Daniel Veillard <veillard>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: c.david86, veillard
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-02-11 04:54:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
specfile patch to fix --nocheck builds none

Description Mark Salter 2013-02-11 00:33:17 UTC
Created attachment 695961 [details]
specfile patch to fix --nocheck builds

Description of problem:

rpmbuild fails when --nocheck used.

Version-Release number of selected component (if applicable):

libxml2-2.9.0-3.fc19

How reproducible:

100%

Steps to Reproduce:
1. rpm -i libxml2-2.9.0-3.fc19.src.rpm
2. rpmbuild -bb --nocheck libxml2.spec
3.
  
Actual results:

cp: cannot stat 'doc/libxml2-api.xml.gz': No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.RRF3do (%doc)


Expected results:

No error.

Additional info:

The problem is that there is some required scripting in the %check section. Simply moving this code to %install doesn't work completely because it removes
files and "make check" has an implicit "make all" which fails because of the missing files. The attached patch works around the problem by moving the problematic scripting out of %check and into %install and using "make runtests" instead of "make check" in %check.

Comment 1 Daniel Veillard 2013-02-11 04:54:54 UTC
Right, thanks for fixing this, my fault :-)

Applied upstream
http://git.gnome.org/browse/libxml2/commit/?id=60adeea933de4abeb431e43454db3433a5427cda

and I rebuilt libxml2-2.9.0-4.fc19 with the fix,
http://koji.fedoraproject.org/koji/taskinfo?taskID=4948504

 thanks !

Daniel