Bug 910496 (kblocks)
Summary: | Review Request: kblocks - A classic falling blocks game | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
Component: | Package Review | Assignee: | nucleo <alekcejk> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | alekcejk, kevin, ltinkl, notting, package-review, than |
Target Milestone: | --- | Flags: | alekcejk:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-02-14 19:01:10 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 908920 | ||
Bug Blocks: | 656997, 907993 |
Description
Rex Dieter
2013-02-12 18:23:16 UTC
Code under GPLv2+ license, doc under GFDL, license tag must be: License: GPLv2+ and GFDL COPYING.DOC must be added in %doc. README.PACKAGERS useless, should be removed. More detailed %description from documentation: KBlocks is the classic falling blocks game. The idea is stack the falling blocks in a way that lines are completely filled. When a line is completed it is removed, and more space is available in the play area. When there is not enough space for blocks to fall, the game is over. $ rpmlint kblocks-4.10.0-1.fc18.i686.rpm kblocks-debuginfo-4.10.0-1.fc18.i686.rpm kblocks-4.10.0-1.fc18.src.rpm kblocks.spec kblocks.i686: W: no-manual-page-for-binary kblocks kblocks.src:70: W: macro-in-comment %{name} kblocks.spec:70: W: macro-in-comment %{name} 3 packages and 1 specfiles checked; 0 errors, 3 warnings. Commented line should be removed. Spec URL: http://rdieter.fedorapeople.org/rpms/kdegames/kblocks.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegames/kblocks-4.10.0-2.fc18.src.rpm %changelog * Thu Feb 14 2013 Rex Dieter <rdieter> 4.10.0-2 - License: GPLv2+ and GFDL - update %%description Remove "%doc README", no such file there, everything else looks fine now. MUST Items: + rpmlint output $ rpmlint kblocks-4.10.0-1.fc18.i686.rpm kblocks-debuginfo-4.10.0-1.fc18.i686.rpm kblocks-4.10.0-2.fc18.src.rpm kblocks.spec kblocks.i686: W: no-manual-page-for-binary kblocks 3 packages and 1 specfiles checked; 0 errors, 1 warnings. + named and versioned according to the Package Naming Guidelines. Package name match the upstream tarball name kblocks-4.10.0.tar.xz + spec file name kblocks.spec matches base package name + complies with all the legal guidelines: + License: GPLv2+ and GFDL, matches actual license (added notices for parts under different licenses) + No known patent problems + No emulator, no firmware, no binary-only or prebuilt components + COPYING (GNU GENERAL PUBLIC LICENSE Version 2), COPYING.DOC (GNU Free Documentation License Version 1.2) packaged as %doc + source matches upstream: MD5: 6080821a1ee6d3df0f22b1242d3e3e5d kblocks-4.10.0.tar.xz SHA1: 969e5de340ed2052b42bf1e0b8a5da3dce41f3da kblocks-4.10.0.tar.xz SHA256: 319724ebb5a8ea12c60dcd586819e2b7e985d012bb65825f764564b068d3ca03 kblocks-4.10.0.tar.xz + builds on at least one arch build from mock is in F18 kde-unstable repo + no known non-working arches, so no ExcludeArch needed + no missing BuildRequires (builds in mock) + locales are handled properly by using %find_lang %{name} --with-kde macro + ldconfig call not needed (no shared libraries) + no duplicated system libraries + package not relocatable (no Prefix tag) + directory ownership correct (doesn't own directories owned by another package, owns all package-specific directories %{_kde4_appsdir}/%{name}/) + no duplicate files in %files + permissions correct, %defattr(-,root,root,-) not needed now, executables have executable permissions + macros used where possible (%{name}, %{version}, %{buildroot}, %{_target_platform}, %{cmake_kde4}, %{_kde4_datadir}, %{_kde4_bindir}, %{_kde4_iconsdir},%{_kde4_appsdir}, %{_kde4_configdir} ) + non-code content: only permitted content, game themes and sounds under license that matches the code + no large documentation files, so no -doc package needed + no %doc files required at runtime + no header files, no -devel package needed + no static libraries, so no -static package needed + no devel symlinks which would need to be in a -devel subpackage + devel packages must require the base package (no -devel package) + no .la files + kblocks.desktop file for the GUI app kblocks present + desktop-file-validate is used in %check and the kblocks.desktop file passes validation + all filenames are valid UTF-8 + other packaging guidelines: + complies with the Filesystem Hierarchy Standard (all files in %{_kde4_datadir}, %{_kde4_bindir}, %{_kde4_iconsdir},%{_kde4_appsdir}, %{_kde4_configdir}) + proper changelog, tags, BuildRequires, Summary, Description (got from kblocks's documentation) + no non-UTF-8 characters + all relevant documentation included as %doc (COPYING, COPYING.DOC) + RPM_OPT_FLAGS are used in %{cmake_kde4} macro + debuginfo package is valid (contains stripped symbols from ELF binary and source code related to it) + no rpaths (no check-rpaths error) + no configuration files, so %config guideline doesn't apply + no init scripts, so init script guideline doesn't apply + timestamps are preserved + %{?_smp_mflags} used + not a web application, so web application guideline doesn't apply + no conflicts (kdegames-4.10.0 is metapackage now which not includes apps) SHOULD Items: + license already included upstream + no translations for description and summary provided by upstream + package builds in mock (built for kde-unstable) - successfully tested the package functionality (no testing yet) + scriptlets are sane (updating icon chache in %post, %postun, %posttrans) + subpackages other than devel should require the base package using a fully versioned dependency (no subpackages) + no .pc files, so "placement of .pc files" is irrelevant + no file dependencies - package should contain man pages for binaries/scripts APPROVED New Package SCM Request ======================= Package Name: kblocks Short Description: A classic falling blocks game Owners: than rdieter jreznik kkofler ltinkl rnovacek Branches: f17 f18 InitialCC: Git done (by process-git-requests). imported |