Bug 910550

Summary: dracut does not add <ipaddr>-kickstart boot option inst.ks= ends with slash
Product: [Fedora] Fedora Reporter: Edgar Hoch <edgar.hoch>
Component: anacondaAssignee: Anaconda Maintenance Team <anaconda-maint-list>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 18CC: anaconda-maint-list, dracut-maint, g.kaviyarasu, harald, jonathan, sbueno, vanmeeuwen+fedora
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-02-13 16:45:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch for usr/lib/dracut/hooks/initqueue/online/10-fetch-kickstart-net.sh in initrd.img of Fedora 18 none

Description Edgar Hoch 2013-02-12 20:20:09 UTC 
Created attachment 696614 [details]
Patch for usr/lib/dracut/hooks/initqueue/online/10-fetch-kickstart-net.sh in initrd.img of Fedora 18

Description of problem:
Fedora 18 does not add "<ipaddr>-kickstart" when the boot option inst.ks= ends with a slash.

Anaconda boot options tells:
http://wwoods.fedorapeople.org/doc/boot-options.html#_inst_ks

  if the filename given ends in /, <ip>-kickstart is added 

This has worked with Fedora 16 and (most) previous versions.


Version-Release number of selected component (if applicable):
Fedora 18 x86_64 network boot with option inst.ks= which ends with a slash

How reproducible:
Always.

Steps to Reproduce:
1. Boot with boot option like ks=nfs:fileserver:/path/to/kickstartfiles/
 
Actual results:
Fedora tries to copy the directory (with cp command) to /tmp/ks.cfg .
This creates an error that cp does ignore the directory /run/nfs_mnt0// .

Expected results:
Fedora should copy the file /run/nfs_mnt0/<ipaddr>-kickstart to /tmp/ks.cfg .

Additional info:

The file
  usr/lib/dracut/hooks/initqueue/online/10-fetch-kickstart-net.sh
in initrd.img of Fedora 18 adds "<ipaddr>-kickstart" only if the kickstart filepath is autogenerated ("nfs:auto"). I think this is wrong: "<ipaddr>-kickstart" should be added whenever the given or autogenerated kickstart path ends with a slash (as written in the wiki).

I have created a patch for that file in initrd.img.
Comment 1 Harald Hoyer 2013-02-13 10:59:56 UTC 
10-fetch-kickstart-net.sh is part of anaconda.
Comment 2 Chris Lumens 2013-02-13 16:39:49 UTC 
After a bit of discussion here, what we've determined is that your patch does restore the old behavior from previous versions of anaconda.  However, that behavior did not match the documentation which states the <ip-addr>-kickstart bit only gets used if your command line parameter is just "ks".

On the other hand, we don't really have any objections to taking your patch to restore old behavior and update the docs to match.  So that's what we are going to do.  Thanks for the patch.