Bug 910565
| Summary: | Review Request: python-github - A Python library implementing the full Github API v3. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jiri Moskovcak <jmoskovc> |
| Component: | Package Review | Assignee: | Richard Marko <rmarko> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | a.badger, dfediuck, jberan, lmacken, package-review, rmarko |
| Target Milestone: | --- | Flags: | rmarko:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-12-03 13:17:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jiri Moskovcak
2013-02-12 21:06:14 UTC
* Doesn't build in mock due to missing python-setuptools BuildReqs * python-sitelib macro definition is not necessary * rpmlint complains about * python-github.src:12: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 12) * python-github.noarch: W: incoherent-version-in-changelog 1.10.0-1 ['1.11.1-1.fc18', '1.11.1-1'] Please fix these minor issues. - fixed & updated the files referenced in c#1 - btw it also complains about missing docs, but they are there: /usr/lib/python2.7/site-packages/github/doc/ > - fixed & updated the files referenced in c#1 Thanks. > - btw it also complains about missing docs, but they are there: > /usr/lib/python2.7/site-packages/github/doc/ It's possible to move them to proper location with ... %build %{__python} setup.py build mv build/lib/github/doc/ . ... %files %defattr(-,root,root,-) # For noarch packages: sitelib %doc doc %{python_sitelib}/* Problem is that there's no copy of the license in the release tarball. It's included in the setup.py file but missing from the tarball generated with python setup.py sdist. I started packaging this last night before finding this. Some comments from that attempt:
* Package appears to be LGPLv3+, not GPLv2+ (see the comment headers of the source files, for instance GitObject.py)
* License files and other docs are in the github directory and should be moved out to %doc. As Richard Marko points out, you can do this with mv. But there's more than just the github/doc directory: COPYING, COPYING.LESSER, and ReadMe.md
* Need to run the tests during the build:
%check
%{__python} setup.py test
* Should exclude the tests from the binary package (I grepped for tests and import in the source to determine that they weren't needed at runtime):
%files
[...]
%exclude %{python_sitelib}/github/tests
Fixed version according to c#3 && c#4 http://jmoskovc.fedorapeople.org/python-github.spec http://jmoskovc.fedorapeople.org/python-github-1.11.1-2.fc18.src.rpm (In reply to comment #5) > Fixed version according to c#3 && c#4 > > http://jmoskovc.fedorapeople.org/python-github.spec > http://jmoskovc.fedorapeople.org/python-github-1.11.1-2.fc18.src.rpm * Package name correct * Packaging latest version * License ok and good for fedora * SPEC file clean and legible * Builds fine in mock * Sane filelist * Sane reqs/provs => Package approved. Few minor issue that should be fixed: [!]: Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires %install: rm -rf %{buildroot} present but not required %clean: rm -rf %{buildroot} present but not required New Package SCM Request ======================= Package Name: python-github Short Description: A Python library implementing the full Github API v3 Owners: jmoskovc Branches: f17 f18 InitialCC: Git done (by process-git-requests). |