Bug 910711
| Summary: | snapshot-revert causes spurious hardware mismatch errors | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Community] Virtualization Tools | Reporter: | Francois Gouget <fgouget> | ||||||
| Component: | libvirt | Assignee: | Peter Krempa <pkrempa> | ||||||
| Status: | CLOSED UPSTREAM | QA Contact: | |||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | unspecified | CC: | acathrow, eblake, pkrempa | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-09-16 12:04:57 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Francois Gouget
2013-02-13 11:14:12 UTC
I have now retested this with a slightly modified configuration, specifically libvirt 1.0.2 and QEmu 1.1.2. Strangely enough I don't get the hardware mismatch errors. So to summarize: libvirt 0.9.12 and QEmu 1.1.2: No problem libvirt 1.0.2 and QEmu 1.1.2: No problem libvirt 1.0.2 and QEmu 1.3.90: Spurious errors So it seems the problem comes from QEmu 1.3.90 rather than libvirt. Does that make sense? Here are the new configuration details: ipxe-qemu 1.0.0+git-20120202.f6840ba-3 libvirt-bin 1.0.2-2 libvirt-doc 1.0.2-1 libvirt0 1.0.2-2 libvirtodbc0 6.1.4+dfsg1-5 python-libvirt 1.0.2-2 qemu 1.1.2+dfsg-5 qemu-keymaps 1.4.0~rc0+dfsg-1exp qemu-kvm 1.1.2+dfsg-5 qemu-system 1.1.2+dfsg-5 qemu-user 1.1.2+dfsg-5 qemu-utils 1.1.2+dfsg-5 Can you show 'virsh dumpxml' output for the running domain under libvirt 1.0.2 with both versions of qemu? I have to wonder if it has something to do with newer qemu enabling a feature that older qemu did not have, and where the new feature causes libvirt to rearrange controller objects when it should not be doing so. Created attachment 698342 [details]
dumpxml done with libvirt 1.0.2 and QEmu 1.1.2
Created attachment 698343 [details] dumpxml done with libvirt 1.0.2 and QEmu 1.3.90 Note that I cannot revert to a QEmu 1.1.2 snapshot with QEmu 1.3.90 (*) so this is from a different snapshot. Both were made from the same not-live snapsot by booting the VM and taking a live snapshot. So for the tests I did something like this: $ virsh --connect qemu:///system destroy fgtbwinxp $ virsh --connect qemu:///system snapshot-revert fgtbwinxp wtb # And again $ virsh --connect qemu:///system snapshot-revert fgtbwinxp wtb Replace wtb with wtb1390 for QEmu 1.3.90. The first snapshot-revert works fine in both cases. With QEmu 1.3.90 the second one claims it requires force. (*) See QEmu bug 1123975: https://bugs.launchpad.net/bugs/1123975 This issue is now fixed upstream with:
commit 53c39f5837a6eed543465a7a55690786d0655ad0
Author: Peter Krempa <pkrempa>
Date: Thu Sep 12 11:37:57 2013 +0200
qemu: Fix checking of guest ABI compatibility when reverting snapshots
When reverting a live internal snapshot with a live guest the ABI
compatiblity check was comparing a "migratable" definition with a normal
one. This resulted in the check failing with:
revert requires force: Target device address type none does not match source pci
This patch generates a "migratable" definition from the actual one to
check against the definition from the snapshot to avoid this problem.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1006886
Thanks for reporting it.
|