Bug 910891

Summary:	Review Request: python-subprocess32 - Backport of subprocess module from Python 3.2 to Python 2.*
Product:	[Fedora] Fedora	Reporter:	Dave Malcolm <dmalcolm>
Component:	Package Review	Assignee:	Toshio Ernie Kuratomi <a.badger>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	a.badger, danken, dmalcolm, notting, package-review
Target Milestone:	---	Flags:	a.badger: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	python-subprocess32-3.2.3-1.fc18	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-10-01 02:10:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dave Malcolm 2013-02-13 19:34:59 UTC

Spec URL: http://dmalcolm.fedorapeople.org/python-packaging/python-subprocess32.spec
SRPM URL: http://dmalcolm.fedorapeople.org/python-packaging/python-subprocess32-3.2.3-1.fc17.src.rpm
Description: Backport of the subprocess module from Python 3.2 for use on 2.x.
Fedora Account System Username: dmalcolm

Successful scratch build in Koji:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=4958971

$ rpmlint ~/rpmbuild/RPMS/x86_64/python-subprocess32-*
python-subprocess32.x86_64: W: spelling-error Summary(en_US) Backport -> Back port, Back-port, Backpacker
python-subprocess32.x86_64: W: spelling-error Summary(en_US) subprocess -> sub process, sub-process, processors
python-subprocess32.x86_64: W: spelling-error %description -l en_US Backport -> Back port, Back-port, Backpacker
python-subprocess32.x86_64: W: spelling-error %description -l en_US subprocess -> sub process, sub-process, processors
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

I believe the rpmlint warnings are inconsequential (certainly "subprocess" is the correct spelling, given the context).

Comment 1 Toshio Ernie Kuratomi 2013-02-13 23:34:21 UTC

70c846c207c85d4a2dfbf2d3990e167767fed9db192353c7f068c653731e6b0b  subprocess32-3.2.3.tar.gz

Good:
* package named appropriately
* spec name meets guidelines
* license is correct and approved
* LICENSE file is included
* Spec file is legible
* Source matches upstream
* Builds in koji
* No locale files
* Not a shared library
* No bundled libraries
* Not relocatable
* Package owns all files and directories it creates and none that other packages create
* No files listed twice
* Permissions set properly
* Macros used consistently
* Code, not content
* No large docs
* Nothing in %doc affects runtime
* Not a GUI app
* All filenames valid UTF-8
* No scriptlets
* No subpackages

rpmlint:
* All spelling warnings and they are all false positives.

Cosmetic:
* Doesn't need -O1 in "%{__python} setup.py install -O1:

APPROVED

Comment 2 Dave Malcolm 2013-02-14 17:27:45 UTC

New Package SCM Request
=======================
Package Name: python-subprocess32
Short Description: Backport of subprocess module from Python 3.2 to Python 2
Owners: dmalcolm
Branches: f17 f18
InitialCC:

Comment 3 Gwyn Ciesla 2013-02-14 17:37:37 UTC

Git done (by process-git-requests).

Comment 4 Fedora Update System 2013-02-14 19:03:25 UTC

python-subprocess32-3.2.3-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/python-subprocess32-3.2.3-1.fc17

Comment 5 Fedora Update System 2013-02-14 19:03:50 UTC

python-subprocess32-3.2.3-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/python-subprocess32-3.2.3-1.fc18

Comment 6 Fedora Update System 2013-02-16 01:02:38 UTC

python-subprocess32-3.2.3-1.fc18 has been pushed to the Fedora 18 testing repository.

Comment 7 Fedora Update System 2013-10-01 02:10:03 UTC

python-subprocess32-3.2.3-1.fc18 has been pushed to the Fedora 18 stable repository.

Comment 8 Dan Kenigsberg 2016-03-28 11:42:36 UTC

Dave, would you be kind to build python-subprocess32 for EPEL7 ?

Comment 9 Dave Malcolm 2019-10-25 09:07:01 UTC

(In reply to Dan Kenigsberg from comment #8)
> Dave, would you be kind to build python-subprocess32 for EPEL7 ?

I'm no longer able to maintain this package in Fedora (upstream GCC duties take all my time), but Looking at
  https://apps.fedoraproject.org/packages/python-subprocess32/builds/
it appears that this is now in EPEL 7.