Bug 911091

Summary:	[User Portal] UserVmManager cannot edit Custom properties
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Jiri Belka <jbelka>
Component:	ovirt-engine-userportal	Assignee:	Oved Ourfali <oourfali>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Jiri Belka <jbelka>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	3.2.0	CC:	acathrow, dyasny, ecohen, iheim, michal.skrivanek, Rhev-m-bugs, sgrinber, ykaul
Target Milestone:	---
Target Release:	3.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	virt
Fixed In Version:	sf9	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	915537

Description Jiri Belka 2013-02-14 10:58:59 UTC

Description of problem:
If I understand that correctly custom properties should be edited only in Administration Portal. UserVmManager cannot edit it in the UP, although SuperUser role can edit it in the UP.

So either "hide" for all irrelevant roles in the UP, or remote it completely from the UP like 'Host' side-menu in 'Edit VM' dialog is removed from the UP.

If there should be way to edit Custom properties in the UP, then please state clearly which roles should see this menu and which should be able to edit them.

Version-Release number of selected component (if applicable):
sf7

How reproducible:
100%

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Jiri Belka 2013-02-14 11:22:47 UTC

2013-02-14 12:22:08,718 WARN  [org.ovirt.engine.core.bll.UpdateVmCommand] (ajp-/127.0.0.1:8702-9) [6f4a9667] CanDoAction of action UpdateVm failed. Reasons:VAR__ACTION__UPDATE,VAR__TYPE__VM,USER_NOT_AUTHORIZED_TO_PERFORM_ACTION

Comment 2 Oved Ourfali 2013-02-17 11:31:07 UTC

Currently we never enable/disable options in the UI according to the permissions.
In this case, in order to update the custom properties, you need one of the following roles:

SuperUser
ClusterAdmin
DataCenterAdmin

Simon - is there any other role that you think such a permission is relevant to?
If not, assuming all the roles above are administrator roles, then it would be a good idea to remove it.

Comment 7 Jiri Belka 2013-02-22 12:11:33 UTC

Not working in new build - sf8. Still Custom Properties visible in UP and if UserVmManager tries to add a property the action is denied. I suppose you want to hide it, right?

Comment 9 Jiri Belka 2013-03-05 13:50:03 UTC

OK, sf9, custom properties not visible anymore in UP.

Comment 10 Itamar Heim 2013-06-11 08:56:25 UTC

3.2 has been released

Comment 11 Itamar Heim 2013-06-11 08:56:25 UTC

3.2 has been released

Comment 12 Itamar Heim 2013-06-11 08:56:34 UTC

3.2 has been released

Comment 13 Itamar Heim 2013-06-11 08:59:04 UTC

3.2 has been released

Comment 14 Itamar Heim 2013-06-11 09:28:31 UTC

3.2 has been released