Bug 911833
| Summary: | The Patch file 'secure-boot-3.7-20130204.patch' needs correction for non-EFI cases | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Bowey <support> | ||||
| Component: | kernel | Assignee: | Josh Boyer <jwboyer> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 18 | CC: | gansalmon, itamar, jonathan, kernel-maint, madhu.chinakonda, schaiba, support | ||||
| Target Milestone: | --- | Keywords: | Patch | ||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-02-19 00:55:46 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Fixed with attached patch for 'secure-boot-3.7-20130204.patch' Thanks for the report. I'll get this fixed up today. Slightly different patch, but should work now. Fixed in 3.8.0-1. |
Created attachment 698098 [details] Changed patch file with required EFI change to /arch/x86/kernel/setup.c Description of problem: kernel-3.7.8-202.fc18.src.rpm: Compile fails if 'CONFIG_EFI' not defined on build Version-Release number of selected component (if applicable): kernel-3.7.8-202 How reproducible: Disable EFI Boot, then Build [rpmbuild]Kernel. Steps to Reproduce: 1. Disable EFI 2. Build / Compile Kernel 3. Actual results: "undefined reference to `x86_efi_facility'" Expected results: Additional info: The submitted PATCH 'secure-boot-3.7-20130204.patch' file is wrong: For /arch/x86/kernel/setup.c it shows this: // -------------------------------------------- if (boot_params.secure_boot) { set_bit(EFI_SECURE_BOOT, &x86_efi_facility); secureboot_enable(); } // -------------------------------------------- Here is the corrected EFI patch for the patch file 'secure-boot-3.7-20130204.patch' (Starting from #244 of secure-boot-3.7-20130204.patch) // -------------------------------------------- +#ifdef CONFIG_EFI if (boot_params.secure_boot) { set_bit(EFI_SECURE_BOOT, &x86_efi_facility); secureboot_enable(); } +#endif // -------------------------------------------- I have added the amended the changed patch file here: (same file-name - just the correction made above) With the above change, the Kernel Build now completes successfully.