Bug 911894 (kshutdown2)
| Summary: | Review Request: kshutdown2 - advanced shut down utility for KDE 4 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Grulich <jgrulich> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | kevin, notting, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-02-17 14:24:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997 | ||
|
Description
Jan Grulich
2013-02-16 14:10:22 UTC
Not a full review, but some remarks: * Why call this package "kshutdown2" rather than just "kshutdown"? Especially considering that it's actually version 3 and I see nothing upstream using the -2 suffix. * Version 3.0.1beta6 is not valid according to the naming/versioning guidelines: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages * At least the long %description should explain what this tool does that the builtin KDE Plasma shutdown dialog doesn't do. For example, the screenshot shows timed shutdowns. 1) Because we already have kshutdown package which is for KDE 3. So I decided to make it as a new package instead of updating the old package and it is called kshutdown2 because the branch in svn repository is called kshutdown2. Update: Spec URL: http://jgrulich.fedorapeople.org/kshutdown2.spec SRPM URL: http://jgrulich.fedorapeople.org/kshutdown2-3.0-2.beta6.fc18.fc18.src.rpm Damn, wrong link Update: Spec URL: http://jgrulich.fedorapeople.org/kshutdown2.spec SRPM URL: http://jgrulich.fedorapeople.org/kshutdown2-3.0-2.beta6.fc18.src.rpm You're going to Obsolete the old KDE 3 version anyway, so you should claim ownership of the old package and update that. And Release: 2.beta6 is still not compliant to the guidelines, it should be 0.1.beta6, 0.2.beta6, 0.3.beta6 etc. The idea is that it must be smaller than 1, which is used by the first package of the actual 3.0 release. Now if Chitlesh is not responding to your ACL requests (nor willing to upgrade the package himself), you should start the nonresponsive maintainer procedure: https://fedoraproject.org/wiki/Policy_for_nonresponsive_package_maintainers Obsoleting a package without that package's maintainer's consent is not acceptable anyway. |