Bug 911907

Summary: Please re-enable rrdcached plugin
Product: [Fedora] Fedora Reporter: Tomasz Torcz <tomek>
Component: collectdAssignee: Ruben Kerkhof <ruben>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 18CC: apevec, mail, rjones
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: collectd-5.3.0-1.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-04-30 20:20:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
add rrdcached to spec none

Description Tomasz Torcz 2013-02-16 16:08:29 UTC 
Description of problem:
rrdcached plugin was disabled in .spec two years ago. This plugin greatly helps scalabitity when collecting lot of statistics. Please reenable.

Version-Release number of selected component (if applicable):
collectd-5.2.0-1.fc18.x86_64
Comment 1 Alan Pevec 2013-02-16 23:29:40 UTC 
> rrdcached plugin was disabled in .spec two years ago.

If you mean http://pkgs.fedoraproject.org/cgit/collectd.git/commit/?id=a9b5a4f6e38a5e7e3d3876d77c552d2abf347ea6
that was just making explicit what configure was doing in buildroot with BRs at that time.
I'd appreciate if you could test rrdcached and attach the patch - not sure would it better make sense in the current collectd-rrdtool or in its own subpackage?
Comment 2 Tomasz Torcz 2013-02-19 10:21:12 UTC 
Created attachment 699396 [details]
add rrdcached to spec

I think it makes more sense inside collectd-rrdtool subpackage, although I've commented out autoloading. Administrator will have to choose, with rrdtool being the default after installation of collectd-rrdtool.

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5032150
Comment 3 Tomasz Torcz 2013-02-19 10:27:08 UTC 
Oh crap, patch was mangled somehow. You can get it from http://pipebreaker.pl/dump/0001-enable-rrdcached-plugin-rhbz-911907.patch

BTW, there are some helper systemd macros for all those pre/post/un invocations: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Macroized_scriptlets_.28Fedora_18.2B.29
Comment 4 Tomasz Torcz 2013-03-22 14:15:24 UTC 
Alan,

Have you had time to look at this?
Comment 5 Alan Pevec 2013-04-30 20:20:38 UTC 
Sorry I hadn't but Ruben fixed it in Rawhide.
Let me know if you really need it in F18 and I'll look at backporting it from master branch.
Comment 6 Tomasz Torcz 2013-04-30 23:24:48 UTC 
I'd like to see it in F19. For F18 I can rebuild rpm myself.
Thanks!