Bug 912477
Summary: | Review Request: perl-Filesys-SmbClient - Samba client Perl module | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Normunds <fedorapkg> |
Component: | Package Review | Assignee: | Petr Šabata <psabata> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | notting, package-review, psabata |
Target Milestone: | --- | Flags: | psabata:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-02-28 06:58:30 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Normunds
2013-02-18 18:39:59 UTC
Builds were tested with koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5023207 http://koji.fedoraproject.org/koji/taskinfo?taskID=5023350 http://koji.fedoraproject.org/koji/taskinfo?taskID=5023450 http://koji.fedoraproject.org/koji/taskinfo?taskID=5023612 Installed package was tested with upstream package tests: [fedora18] Filesys-SmbClient-3.2 $ perl t/* 1..19 ok 1 - Load module ok 2 - Create directory ok 3 - Create existent directory ok 4 - Create file ok 5 - Rename file ok 6 - Stat file ok 7 - Stat non-existent file ok 8 - Read file ok 9 - Read short directory ok 10 - Read long directory ok 11 - Unlink file ok 12 - Unlink non-existent file ok 13 - Create directory ok 14 - Create directory ok 15 - Rmdir entire directory ok 16 - Rm directory ok 17 - Rm non-existent directory ok 18 - Rename non-existent file There is a .c file in this directory with info about your params for you SMB server test. Think to remove it if you have finish with test. ok 19 - shutdown [fedora18] Filesys-SmbClient-3.2 $ perl t/02tie.t 1..25 ok 1 - Create directory ok 2 - tie & open ok 3 - TIE: return of syswrite ok 4 - TIE: return of syswrite on a closed filehandle ok 5 - TIE: tie & open a file stat() on unopened filehandle FD at /usr/share/perl5/File/Copy.pm line 138, <F> line 1. ok 6 - copy a filehandle with File::Copy ok 7 - TIE: Read one ligne of a file ok 8 - TIE: Read another ligne of a file ok 9 - TIE: getc of a file ok 10 - TIE: getc of a file ok 11 - TIE: getc of a file ok 12 - TIE: getc of a file ok 13 - TIE: seek SEEK_SET a file ok 14 - TIE: Return of read ok 15 - TIE: buffer read ok 16 - TIE: Seek SEEK_CUR a file open ok 17 - TIE: Seek SEEK_END a file open ok 18 - TIE: sysread return 0 at end of file ok 19 - TIE: seek return undef on closed file ok 20 - TIE: read return undef on closed file ok 21 - TIE: sysread return undef on closed file ok 22 - TIE: Read a file in list context ok 23 - Unlink file ok 24 - TIE: open a non-existent file ok 25 - Rm directory [fedora18] Filesys-SmbClient-3.2 $ perl t/03tie_perl56.t 1..20 ok 1 - Create directory ok 2 - TIE: open to create a file ok 3 - TIE: return of syswrite ok 4 - TIE: return of syswrite on a closed filehandle ok 5 - TIE: read a file ok 6 - TIE: Read one ligne of a file ok 7 - TIE: Read another ligne of a file ok 8 - TIE: getc of a file ok 9 - TIE: getc of a file ok 10 - TIE: getc of a file ok 11 - TIE: getc of a file ok 12 - TIE: seek SEEK_SET a file ok 13 - TIE: Return of read ok 14 - TIE: buffer read ok 15 - TIE: seek closed file ok 16 - TIE: read closed file ok 17 - TIE: Read a file in list context ok 18 - Unlink file ok 19 - TIE: open a non-existent file ok 20 - Rm directory [fedora18] Filesys-SmbClient-3.2 $ Upstream is notified about rpmlint license issue here: https://rt.cpan.org/Public/Bug/Display.html?id=83366 The license address is not a blocker.
Since your package doesn't run the tests (for stated reasons), you can remove most of your BRs, keeping just perl(ExtUtils::MakeMaker) and perl(ExtUtils::MakeMaker).
> 54 perl Makefile.PL INSTALLDIRS=vendor CCFLAGS='-DHAVE_CLOSEFN'
This is an arch-dependent module, add OPTIMIZE="%{optflags}" here.
The rest of the package looks good.
Thanks :) * Removed BuildRequires except MakeMaker and samba dependency. * Added OPTIMIZE to Makefile.PL * Re-tested with Mock, currently re-testing with koji. Will post a note here if something fails (max 2 hours from now). Best regards. The current state is good enough for the review now. Approving. Thanks :) New Package SCM Request ======================= Package Name: perl-Filesys-SmbClient Short Description: Samba client Perl module Owners: normunds psabata Branches: f17 f18 InitialCC: perl-sig Git done (by process-git-requests). perl-Filesys-SmbClient-3.2-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Filesys-SmbClient-3.2-1.fc17 perl-Filesys-SmbClient-3.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Filesys-SmbClient-3.2-1.fc18 perl-Filesys-SmbClient-3.2-1.fc18 has been pushed to the Fedora 18 testing repository. perl-Filesys-SmbClient-3.2-1.fc18 has been pushed to the Fedora 18 stable repository. perl-Filesys-SmbClient-3.2-1.fc17 has been pushed to the Fedora 17 stable repository. |