Bug 912615

Summary: Virt-install on RHEL7 still keeps vnc as default graphics
Product: Red Hat Enterprise Linux 7 Reporter: Geyang Kong <gkong>
Component: virt-managerAssignee: Martin Kletzander <mkletzan>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.0CC: codong, cwei, dyuan, lcui, mjenner, mkletzan, mzhan, tzheng
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: virt-manager-0.10.0-2.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-13 12:02:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 883470    
Bug Blocks:    

Description Geyang Kong 2013-02-19 08:13:31 UTC
Description of problem:
  Virt-install on RHEL7 still keeps vnc as default graphics

Version-Release number of selected component (if applicable):
python-virtinst-0.600.3-2.el7.noarch

Reproduce steps:
1. run following command:
#virt-install     --connect=qemu:///system     -n T1     -r 1024     -f /var/lib/libvirt/images/T1.img     -s 6     -m 52:54:00:42:36:7c     -l http://tree.englab.nay.redhat.com/pub/rhel/released/RHEL-6/6.3/Server/x86_64/os/     -x ks=http://home.englab.nay.redhat.com/~nzhang/kickstart/http/ks-rhel6-x86_64.cfg     --noreboot
2. run #man virt-install

Actual results:
1. Guest has a vnc graphic device
2. In man page, it said: If no graphics option is specified, "virt-install" will default to '--graphics vnc'.

Expected results:
1. Guest should have a spice graphic device.
2. Man page should be updated to.

Additional info:
1. virt-manager on rhel7 already treated spice as its default graphic device, virt-install should do same thing for this.
2. For most of our advanced functions, such as smart-card, usb-redirection, multiple monitors are based on spice, so I think we'd better set spice as the default choice.

Comment 1 Martin Kletzander 2013-02-19 12:03:47 UTC
Let's wait for bug 883470 to pass since the patch for this should be trivial.

Comment 2 CongDong 2013-06-14 02:44:29 UTC
I can reproduce this with virt-manager-0.10.0-0.2.gitb68faac8.el7. So I think this bug is not fixed.

# rpm -qa virt-manager
virt-manager-0.10.0-0.4.gitb68faac8.el7.noarch

1. run following command:
#virt-install     --connect=qemu:///system     -n T1     -r 1024     -f /var/lib/libvirt/images/T1.img     -s 6     -m 52:54:00:42:36:7c     -l http://tree.englab.nay.redhat.com/pub/rhel/released/RHEL-6/6.3/Server/x86_64/os/     -x ks=http://home.englab.nay.redhat.com/~nzhang/kickstart/http/ks-rhel6-x86_64.cfg     --noreboot
2. run #man virt-install

Result:
Step 1: Check the xml of guest
# virsh dumpxml T1
...
 <graphics type='vnc' port='-1' autoport='yes'/>
...
It's still vnc type

Step 2:Check the man page of virt-install
# man virt-install
If no graphics option is specified, "virt-install" will default to
       '--graphics vnc' if the DISPLAY environment variable is set, otherwise
       '--graphics none' is used.

Comment 3 Martin Kletzander 2013-06-18 08:36:31 UTC
Sorry for that, I repaired the 'Fixed in version' field.

Comment 4 CongDong 2013-06-18 08:50:46 UTC
(In reply to Martin Kletzander from comment #3)
> Sorry for that, I repaired the 'Fixed in version' field.

I tried with :
# rpm -qa virt-manager virt-install
virt-install-0.10.0-0.5.gitde1695b2.el7.noarch
virt-manager-0.10.0-0.5.gitde1695b2.el7.noarch

But I got the same result with comment #2 .

Comment 5 Martin Kletzander 2013-07-15 09:15:24 UTC
Final patch proposed upstream:

https://www.redhat.com/archives/virt-tools-list/2013-July/msg00078.html

Comment 6 Martin Kletzander 2013-07-16 06:10:14 UTC
Moving to POST with commit v0.10.0-144-gb8a209e:

commit b8a209ef9c82c006a88edb6b06a9e481987ee779
Author: Martin Kletzander <mkletzan>
Date:   Thu Jul 11 15:42:31 2013 +0200

    virt-install: Make default graphics configurable

Comment 11 luxin 2013-08-14 02:29:08 UTC
I can reproduce this bug:

Version:
python-virtinst-0.600.3-2.el7.noarch

Steps for Reproduce:
1. run following command:
#virt-install     --connect=qemu:///system     -n T1     -r 1024     -f /var/lib/libvirt/images/T1.img     -s 6     -m 52:54:00:42:36:7c     -l http://tree.englab.nay.redhat.com/pub/rhel/released/RHEL-6/6.3/Server/x86_64/os/     -x ks=http://home.englab.nay.redhat.com/~nzhang/kickstart/http/ks-rhel6-x86_64.cfg     --noreboot

2. run # man virt-install

Result:
1. After step 1, #virsh dumpxml T1
...
 <graphics type='vnc' port='5900' autoport='yes' listen='127.0.0.1'>
...

2. After step 2. check man page of virt-install
If no graphics option is specified, "virt-install" will default to '--graphics vnc' if the DISPLAY environment variable is set, otherwise '--graphics none' is used.

Verify:
virt-install-0.10.0-2.el7.noarch.rpm 
virt-manager-0.10.0-2.el7.noarch.rpm 
virt-manager-common-0.10.0-2.el7.noarch.rpm 

Steps for Verify:
1. run following command:
#virt-install     --connect=qemu:///system     -n T1     -r 1024     -f /var/lib/libvirt/images/T1.img     -s 6     -m 52:54:00:42:36:7c     -l http://tree.englab.nay.redhat.com/pub/rhel/released/RHEL-6/6.3/Server/x86_64/os/     -x ks=http://home.englab.nay.redhat.com/~nzhang/kickstart/http/ks-rhel6-x86_64.cfg     --noreboot

2. run # man virt-install

Result:
1. After step 1, #virsh dumpxml T1
...
 <graphics type='spice' port='5900' autoport='yes' listen='127.0.0.1'>
...

2. After step 2. check man page of virt-install
If no graphics option is specified, "virt-install" will try to select the appropriate graphics if the DISPLAY environment variable is set, otherwise '--graphics none' is used.

Comment 12 Ludek Smid 2014-06-13 12:02:05 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.