Bug 912833

Please use "%{name}.xml" instead of "%{channelname}.xml".

Joseph -- Do you still plan on doing this review? If not, I can take it.

resetting assignee - Shawn you can take it if you want

Gregor -- Please fix comment #1 and I will review as soon as I can.

Spec URL: http://brummbq.fedorapeople.org/php-channel-dropbox-php.spec
SRPM URL: http://brummbq.fedorapeople.org/php-channel-dropbox-php-1.3-2.fc17.src.rpm

Thanks for the quick update Gregor!  Unfortunately a few more changes are needed (sorry I did not see them before).

* MUST: Change "%global channelname pear.dropbox-php.org" to "%global channelname pear.dropbox-php.com". You have the correct hostname in Source0, but not in your channelname variable.

* COULD: Change "Source0: http://pear.dropbox-php.com/channel.xml" to "Source0: http://%{channelname}/channel.xml"

* MUST: Change "BuildRequires:  php-pear >= 1:1.4.9-1.2" to "BuildRequires: php-pear(PEAR)".  Always use the virtual provide.

* MUST: Change "%{__pear} channel-delete %{name}" to "%{__pear} channel-delete %{channelname}".  The PEAR command syntax is "pear channel-delete <channel name>" so you must use your channel name.

Remi -- I know the guideline is to use ChannelAlias, but in this case, I believe using "dropbox" (php-channel-dropbox) instead of "dropbox-php" (php-channel-dropbox-php) would be better.  I know they are "guidelines" and not "laws" but I wanted to check with you.

sorry for the lack of response, been assigned some extra work I was not expecting, Iwinski, it is great that you took it :)

Spec URL: http://brummbq.fedorapeople.org/php-channel-dropbox-php.spec
SRPM URL: http://brummbq.fedorapeople.org/php-channel-dropbox-php-1.3-3.fc17.src.rpm

I'm fine with channel 'dropbox-php'. At least thats the official alias and name of the main library. There exists also another dropbox sdk, called just 'dropbox' https://github.com/BenTheDesigner/Dropbox To prevent name conflicts in future it would be also a good idea to not change alias.

Created attachment 705587 [details]
fedora-review

Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 912833

No blockers.  Please let me know if you need any help with setting up the repo, Koji, or Bodhi.

===== APPROVED =====

New Package SCM Request
=======================
Package Name: php-channel-dropbox-php
Short Description: Adds the Dropbox-PHP channel to PEAR
Owners: brummbq
Branches: f17 f18 el6
InitialCC:

Git done (by process-git-requests).

php-dropbox-php-Dropbox-1.0.0-4.fc18, php-channel-dropbox-php-1.3-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/php-dropbox-php-Dropbox-1.0.0-4.fc18,php-channel-dropbox-php-1.3-3.fc18

php-dropbox-php-Dropbox-1.0.0-4.fc18, php-channel-dropbox-php-1.3-3.fc18 has been pushed to the Fedora 18 testing repository.

php-dropbox-php-Dropbox-1.0.0-4.fc18, php-channel-dropbox-php-1.3-3.fc18 has been pushed to the Fedora 18 stable repository.

Package Change Request
======================
Package Name: php-channel-dropbox-php
New Branches: epel7
Owners: siwinski
InitialCC:

Git done (by process-git-requests).