Bug 912878
| Summary: | Review Request: profile-sync-daemon - Offload browser profiles to RAM for speed a wear reduction | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | graysky |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | i, mhroncok, notting, package-review, pahan |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-05-29 09:16:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
graysky
2013-02-19 21:52:15 UTC
After trying for several days to get the web interface for koji to work (still cannot login), I just build via CLI: http://koji.fedoraproject.org/koji/taskinfo?taskID=5037743 You probably shouldn't copy upstream changelog to %changelog, it's simply a changelog of the spec/SRPM. * Tue Feb 19 2013 graysky <graysky> - 5.24-1 - New release 5.24 Should be fine. On the other hand, be sure to add the CHANGELOG and README.md to %doc. Once approved, don't forget to update the Fedora package information in README.md, so the offical package doesn't point users to the unofficial (by official, I mean in Fedora repos). Why there is a Makefile.fedora18 file, when you use Makefile.archlinux? They are identical, but anyway, doesn't make much sense to me. (In reply to comment #2) > You probably shouldn't copy upstream changelog to %changelog, it's simply a > changelog of the spec/SRPM. > > * Tue Feb 19 2013 graysky <graysky> - 5.24-1 > - New release 5.24 > > Should be fine. > > On the other hand, be sure to add the CHANGELOG and README.md to %doc. Once > approved, don't forget to update the Fedora package information in > README.md, so the offical package doesn't point users to the unofficial (by > official, I mean in Fedora repos). Took your suggestions with one exception: should I really include the github README.md in the package? Files: http://repo-ck.com/fedora_rpms/profile-sync-daemon.spec http://repo-ck.com/fedora_rpms/profile-sync-daemon-5.24-2.fc18.src.rpm http://repo-ck.com/fedora_rpms/profile-sync-daemon-5.24-2.fc18.noarch.rpm Koji build log: http://koji.fedoraproject.org/koji/taskinfo?taskID=5038248 > Why there is a Makefile.fedora18 file, when you use Makefile.archlinux? They > are identical, but anyway, doesn't make much sense to me. Ah, my bad. Fixed in 5.24-2 available at the URL above. I updated the upstream code and refreshed the respective files for review: Spec URL: http://repo-ck.com/fedora_rpms/profile-sync-daemon.spec SRPM URL: http://repo-ck.com/fedora_rpms/profile-sync-daemon-5.26-1.fc18.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5046536 Is there anything I can do to help expedite the review process? I have updated the upstream code and refreshed the respective files for review: Spec URL: http://repo-ck.com/fedora_rpms/profile-sync-daemon.spec SRPM URL: http://repo-ck.com/fedora_rpms/profile-sync-daemon-5.29-1.fc18.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5122938 Opps... correct koji task: http://koji.fedoraproject.org/koji/taskinfo?taskID=5122938 I have updated the upstream code and refreshed the respective files for review: Spec URL: http://repo-ck.com/fedora_rpms/profile-sync-daemon.spec SRPM URL: http://repo-ck.com/fedora_rpms/profile-sync-daemon-5.35-1.fc18.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5436525 Closing report per Christopher's request. *** This bug has been marked as a duplicate of bug 968253 *** |