Bug 913252

Summary: It is impossible to switch off URL caching if https protocol is used
Product: [JBoss] JBoss Enterprise BRMS Platform 5 Reporter: Alessandro Lazarotti <alazarot>
Component: BRE (Expert, Fusion)Assignee: Nobody <nobody>
Status: CLOSED UPSTREAM QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: BRMS 5.3.1   
Target Milestone: ---   
Target Release: One Off Releases   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-02-10 03:27:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 873846    

Description Alessandro Lazarotti 2013-02-20 17:52:03 UTC
It is impossible to switch off URL caching if https protocol is used

When used https to load resources from HTTP, a conditional mistake try to cache the content even though CACHE_DIR is null:

// class org.drools.io.impl.UrlResource

    public InputStream getInputStream() throws IOException {
        (...)
            if (lastMod > 0 && lastMod > lastRead) {
                if (CACHE_DIR != null && url.getProtocol().equals("http") || url.getProtocol().equals("https")) {
                    //lets grab a copy and cache it in case we need it in future...
                    cacheStream();
                }
            }
        (...)
    }

IF only "https" was evaluated as true -  ((false && false) || true)  -  so the exit will be true, which should be not the expected behaviour

That code should be:

if (CACHE_DIR != null && (url.getProtocol().equals("http") || url.getProtocol().equals("https"))) {
                    //lets grab a copy and cache it in case we need it in future...
                    cacheStream();
}

Comment 1 Alessandro Lazarotti 2013-03-04 21:18:54 UTC
Pull Request: https://github.com/droolsjbpm/drools/pull/182

Comment 2 JBoss JIRA Server 2013-03-04 21:51:18 UTC
Alessandro Lazarotti <alazarot> updated the status of jira DROOLS-66 to Resolved

Comment 3 JBoss JIRA Server 2013-03-04 21:51:18 UTC
Alessandro Lazarotti <alazarot> made a comment on jira DROOLS-66

merged in 5.3.x, 5.4.x, 5.5.x and master (6.0.x) branch

Comment 4 JBoss JIRA Server 2013-03-04 21:55:05 UTC
Alessandro Lazarotti <alazarot> updated the status of jira DROOLS-66 to Closed

Comment 5 Julian Coleman 2013-03-20 12:41:54 UTC
Included in roll-up #1: BZ-873846

Comment 6 Marek Winkler 2013-04-02 08:16:33 UTC
Verified on 5.3.1.BRMS-P02.

Comment 9 Red Hat Bugzilla 2025-02-10 03:27:29 UTC
This product has been discontinued or is no longer tracked in Red Hat Bugzilla.