Bug 913481
| Summary: | Review Request: perl-Net-SFTP-Foreign - SSH File Transfer Protocol client for Perl | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Normunds <fedorapkg> |
| Component: | Package Review | Assignee: | Petr Šabata <psabata> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, psabata, rvokal |
| Target Milestone: | --- | Flags: | psabata:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-08-13 12:59:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Normunds
2013-02-21 10:38:05 UTC
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5026833 http://koji.fedoraproject.org/koji/taskinfo?taskID=5026938 http://koji.fedoraproject.org/koji/taskinfo?taskID=5026990 http://koji.fedoraproject.org/koji/taskinfo?taskID=5027114 > 2 %global real_version 1.74_05 > 3 Version: 1.74.5 Upstream uses odd version numbers for previous even-numbered development releases so this is okay. However, I'd suggest using '1.74.05' to emphasize this is an unstable release, as done elsewhere. Missing BRs: * perl(Encode) from lib/Net/SFTP/Foreign.pm:17 * perl(Net::SFTP) from t/Net-SFTP-Foreign-Compat.t:5 * perl(POSIX) from lib/Net/SFTP/Foreign/Backend/Unix.pm:12 * perl(Tie::Handle) from lib/Net/SFTP/Foreign.pm:3049 You could also remove the Windows backend from the package completely as this won't ever be used in Fedora. Packaging debug.txt, TODO, rfc/ (even mentioned in %description), and samples/ (if you do, filter out their deps, e.g. with %perl_default_filter) in %doc would be nice. Also include LICENSE for sure. > 38 Requires: perl(lib) > 39 Requires: perl(Cwd) Those two are only used in tests, no reason to require them at runtime. Thank you for thorough review. Spec URL: http://unibackup.rule.lv/FedoraRPM/perl-Net-SFTP-Foreign.spec SRPM URL: http://unibackup.rule.lv/FedoraRPM/perl-Net-SFTP-Foreign-1.74.05-1.fc18.src.rpm * Changed number to 1.74.05 * Added missing BuildRequires * Removing Windows.pm in preparation phase. * Added LICENSE, debug.txt, TODO, rfc/*, samples/* to %doc * Added perl_default_filter * Removed unneeded Requires. Thanks and best regards. (In reply to comment #3) > * Added LICENSE, debug.txt, TODO, rfc/*, samples/* to %doc I'd change "rfc/*" and "samples/*" to plain "rfc" and "samples". That will package the whole directories, not just their contents. Anyhow, everything looks alright now. Approving. Thanks, I am modifying "rfc" and "samples" as you suggest :) New Package SCM Request ======================= Package Name: perl-Net-SFTP-Foreign Short Description: SSH File Transfer Protocol client for Perl Owners: normunds psabata Branches: f17 f18 InitialCC: perl-sig Git done (by process-git-requests). perl-Net-SFTP-Foreign-1.74.05-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Net-SFTP-Foreign-1.74.05-1.fc17 perl-Net-SFTP-Foreign-1.74.05-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Net-SFTP-Foreign-1.74.05-1.fc18 perl-Net-SFTP-Foreign-1.74.05-1.fc18 has been pushed to the Fedora 18 testing repository. |