Bug 914695

Summary: Review Request: php-Smarty2 - Template/Presentation Framework for PHP
Product: [Fedora] Fedora Reporter: Gwyn Ciesla <gwync>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: brwk, notting, package-review, shawn
Target Milestone: ---Flags: fedora: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-03-20 21:40:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 911976    
Attachments:
Description Flags
phpci.log
none
review.txt none

Description Gwyn Ciesla 2013-02-22 14:30:21 UTC 
Description:
Although Smarty is known as a "Template Engine", it would be more accurately
described as a "Template/Presentation Framework." That is, it provides the
programmer and template designer with a wealth of tools to automate tasks
commonly dealt with at the presentation layer of an application. I stress the
word Framework because Smarty is not a simple tag-replacing template engine.
Although it can be used for such a simple purpose, its focus is on quick and
painless development and deployment of your application, while maintaining
high-performance, scalability, security and future growth.

SRPM: http://fedorapeople.org/~limb/review/php-Smarty2/php-Smarty2-2.6.27-1.fc18.src.rpm
SPEC: http://fedorapeople.org/~limb/review/php-Smarty2/php-Smarty2.spec

This is parallel-installable with the existing php-Smarty package that is version 3.x in f18+, and this is for compatibility with older applications, such as gallery2.
Comment 1 Remi Collet 2013-03-09 08:34:15 UTC 
Created attachment 707349 [details]
phpci.log

phpci version 2.13.2.
Comment 2 Remi Collet 2013-03-09 08:34:44 UTC 
Created attachment 707350 [details]
review.txt

Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 914695
Comment 3 Remi Collet 2013-03-09 08:35:53 UTC 
[!]: Rpmlint is run on all rpms the build produces.
	php-Smarty2.noarch: E: incorrect-fsf-address /usr/share/doc/php-Smarty2-2.6.27/COPYING.lib
	Please file a bug upstream

[!]: Each %files section contains %defattr if rpm < 4.4
	as other EL-5 stuff not present (buildroot, ...)
	you can drop the %defattr


I think this is a temporary package, waiting for all application to be compatible with Smarty.

No blocker.

=== APPROVED ===
Comment 4 Gwyn Ciesla 2013-03-11 12:39:48 UTC 
Fabulous, thanks very much for the review!

New Package SCM Request
=======================
Package Name: php-Smarty2
Short Description: Template/Presentation Framework for PHP
Owners: limb
Branches: f18
InitialCC:
Comment 5 Gwyn Ciesla 2013-03-11 12:40:37 UTC 
Git done (by process-git-requests).
Comment 6 Fedora Update System 2013-03-11 13:40:09 UTC 
php-Smarty2-2.6.27-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/php-Smarty2-2.6.27-1.fc18
Comment 7 Fedora Update System 2013-03-11 14:48:28 UTC 
php-Smarty2-2.6.27-1.fc18, gallery2-2.3.2-7.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/php-Smarty2-2.6.27-1.fc18,gallery2-2.3.2-7.fc18
Comment 8 Fedora Update System 2013-03-12 08:57:20 UTC 
Package php-Smarty2-2.6.27-1.fc18, gallery2-2.3.2-7.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing php-Smarty2-2.6.27-1.fc18 gallery2-2.3.2-7.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-3730/php-Smarty2-2.6.27-1.fc18,gallery2-2.3.2-7.fc18
then log in and leave karma (feedback).
Comment 9 Fedora Update System 2013-03-20 21:41:00 UTC 
php-Smarty2-2.6.27-1.fc18, gallery2-2.3.2-7.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.