Bug 914767

Summary: Generating probes from dtrace definition generates compiler warnings
Product: [Fedora] Fedora Reporter: Daniel Berrangé <berrange>
Component: systemtapAssignee: Frank Ch. Eigler <fche>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 18CC: dsmith, fche, jistone, lberk, mjw, nathans, scox, wcohen
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: systemtap-2.1-1.fc18 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-02-25 14:03:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Daniel Berrangé 2013-02-22 17:30:54 UTC
Description of problem:
When building libvirt RPMs we're seeing warnings generated from the GCC that dtrace runs

This can be reproduced standalone as follows:

$ CFLAGS=-Wall /bin/dtrace -o libvirt_probes.o -G -s libvirt_probes.d
/tmp/tmpca8bLT.c:1:8: warning: return type defaults to ‘int’ [-Wreturn-type]
/tmp/tmpca8bLT.c:1:8: warning: ‘__dtrace’ defined but not used [-Wunused-function]
/tmp/tmpca8bLT.c: In function ‘__dtrace’:
/tmp/tmpca8bLT.c:1:1: warning: control reaches end of non-void function [-Wreturn-type]

The first line of that file is

static __dtrace () {}

Which is a bogus signature - should be   static int __dtrace(void) {} though that still won't make the -Wunused-function warnings go away.


Version-Release number of selected component (if applicable):
systemtap-2.0-4.fc18.x86_64

How reproducible:
Always

Comment 1 Frank Ch. Eigler 2013-02-22 17:47:40 UTC
This is corrected in the recent 2.1 release, and will be available as an update(-testing) for f18 before long.

Comment 2 Frank Ch. Eigler 2013-02-22 18:08:39 UTC
Please check fedora18 updates-testing.

Comment 3 Daniel Berrangé 2013-02-25 10:21:38 UTC
Yes, that has fixed the problem