Bug 915376
| Summary: | Don't need to hardcode 'Fedora' | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | jcpunk | ||||
| Component: | httpd | Assignee: | Joe Orton <jorton> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 19 | CC: | jkaluza, jorton, pahan | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-05-29 09:42:59 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Where does the "vendor" macro get defined? On a f18 system I have:
$ rpm --eval '%{vendor}'
%{vendor}
$ rpm --eval '%{_vendor}'
redhat
Koji is importing some macros to define it. Grab any rpm off of http://koji.fedoraproject.org/koji/index and run rpm -qp --qf "%{vendor}" against it. This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle. Changing version to '19'. (As we did not run this process for some time, it could affect also pre-Fedora 19 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19 Given that:
a) vendor is undefined outside of koji we'd still need *some* default vendor string if %{vendor} is undefined, and
b) the Fedora branding is "hard-coded" into the package via index.html
I don't see much point in making this change.
|
Created attachment 702399 [details] patch to make change Description of problem: The 'vstring' macro being set in the spec file can swapped for '%{vendor}'. This should reduce the overhead for when the package migrates to RHEL as well as reduce the number of hard coded values within. Since 'vstring' is the Vendor String, the macro can be used exactly as expected Version-Release number of selected component (if applicable):httpd-2.4.3-17.fc19 How reproducible: 100% Steps to Reproduce: 1. Open spec file 2. Notice hard coded value Actual results: Vendor hard coded Expected results: Use existing macros to avoid hard coding Additional info: