Bug 915962 (CVE-2013-1769)
| Summary: | CVE-2013-1769 telepathy-gabble: NULL pointer dereference when trying to hash caps containing pathological data forms | ||
|---|---|---|---|
| Product: | [Other] Security Response | Reporter: | Kurt Seifried <kseifried> |
| Component: | vulnerability | Assignee: | Red Hat Product Security <security-response-team> |
| Status: | CLOSED ERRATA | QA Contact: | |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | unspecified | CC: | bdpepple, extras-orphan, jlieskov, sander, sebastian |
| Target Milestone: | --- | Keywords: | Security |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | telepathy-gabble 0.16.5, telepathy-gabble 0.17.3 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-07-25 20:48:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 915963, 915966, 917769 | ||
| Bug Blocks: | 916244 | ||
Created telepathy-gabble tracking bugs for this issue Affects: fedora-all [bug 915963] Created telepathy-gabble tracking bugs for this issue Affects: epel-6 [bug 915966] OSS security post: http://www.openwall.com/lists/oss-security/2013/03/04/8 Upstream announcements: http://lists.freedesktop.org/archives/telepathy/2013-March/006377.html (0.16.5) http://lists.freedesktop.org/archives/telepathy/2013-March/006378.html (0.17.3) telepathy-gabble-0.16.5-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. |
Will Thompson (will.thompson.uk) reports: Calculating a XEP-0115 hash involves sorting the fields of data forms in the contact's capabilities according to their field name. wocky_caps_hash_compute_from_lists() does this using this function: gint wocky_data_form_field_cmp (const WockyDataFormField *left, const WockyDataFormField *right) { return strcmp (left->var, right->var); } This will obviously crash if either ->var is NULL, but WockyDataForm validates forms it parses so this shouldn't happen, right? Unfortunately, http://xmpp.org/extensions/xep-0004.html#protocol-field says: > If the <field/> element type is anything other than "fixed" (see below), it > MUST possess a 'var' attribute that uniquely identifies the field in the > context of the form (if it is "fixed", it MAY possess a 'var' attribute). And WockyDataForm implements this correctly: var = wocky_node_get_attribute (node, "var"); if (var == NULL && type != WOCKY_DATA_FORM_FIELD_TYPE_FIXED) { DEBUG ("field node doesn't have a 'var' attribute; ignoring"); return FALSE; } So we have a remotely-triggered DoS: send Gabble a <presence> with a caps hash; include a form with an anonymous fixed field in the reply; boom. Since anyone can send presence to anyone else, and Gabble always looks up any caps it sees in any presences it receives. (Note that this is a presence leak, too; another bug, I think.) I have some fixes; patches to follow. I will also suggest that http://xmpp.org/extensions/xep-0115.html be updated to mention this. External references: https://bugs.freedesktop.org/show_bug.cgi?id=61433 http://lists.freedesktop.org/archives/telepathy-bugs/2013-February/021155.html http://xmpp.org/extensions/xep-0115.html