Bug 916176

Summary:	Add a namespace prefix to glance hardware properties used by libvirt
Product:	Red Hat OpenStack	Reporter:	Daniel Berrangé <berrange>
Component:	openstack-nova	Assignee:	Daniel Berrangé <berrange>
Status:	CLOSED ERRATA	QA Contact:	Kashyap Chamarthy <kchamart>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	2.1	CC:	ndipanov
Target Milestone:	snapshot5	Keywords:	Triaged
Target Release:	2.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-nova-2012.2.3-5.el6ost	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-04-04 20:21:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Daniel Berrangé 2013-02-27 13:15:27 UTC

Description of problem:
Per this bug, upstream is likely going to rename the glance image properties used by libvirt to determine hardware models.

  https://bugs.launchpad.net/nova/+bug/1132739

since we backported these properties to RHOS, we *MUST* do the rename too, otherwise we'll have a huge backcompat problem.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Daniel Berrangé 2013-02-27 13:17:35 UTC

Upstream review for patch https://review.openstack.org/#/c/23081/

Comment 6 Kashyap Chamarthy 2013-03-18 20:03:47 UTC

VERIFIED.

1] Version info:
#-------------#
$ cat /etc/redhat-release ; arch
Red Hat Enterprise Linux Server release 6.4 (Santiago)
x86_64
#-------------#


2] Ensure the fix is in:
#-------------#
$ rpm -q openstack-nova --changelog | grep -i 916176
- Add a namespace prefix to glance hardware properties #916176
#-------------#


3] grep for the namespace prefix in relevant files:
#-------------#
$ grep hw_  -A1 -B1 /usr/lib/python2.6/site-packages/nova/virt/libvirt/blockinfo.py /usr/lib/python2.6/site-pack
ages/nova/virt/libvirt/vif.py
/usr/lib/python2.6/site-packages/nova/virt/libvirt/blockinfo.py-    if image_meta:
/usr/lib/python2.6/site-packages/nova/virt/libvirt/blockinfo.py:        key = "hw_" + device_type + "_bus"
/usr/lib/python2.6/site-packages/nova/virt/libvirt/blockinfo.py-        disk_bus = image_meta.get('properties', {}).get(key)
--
/usr/lib/python2.6/site-packages/nova/virt/libvirt/vif.py-            vif_model = image_meta.get('properties',
/usr/lib/python2.6/site-packages/nova/virt/libvirt/vif.py:                                       {}).get('hw_vif_model')
/usr/lib/python2.6/site-packages/nova/virt/libvirt/vif.py-            if vif_model is not None:
#-------------#

Comment 8 errata-xmlrpc 2013-04-04 20:21:43 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0709.html