|Summary:||Expose cpu_map.xml via API|
|Product:||[Community] Virtualization Tools||Reporter:||Cole Robinson <crobinso>|
|Component:||libvirt||Assignee:||Jiri Denemark <jdenemar>|
|Status:||CLOSED UPSTREAM||QA Contact:|
|Version:||unspecified||CC:||acathrow, berrange, dallan, eblake, gscrivan, jdenemar, lagarcia|
|Fixed In Version:||Doc Type:||Bug Fix|
|Doc Text:||Story Points:||---|
|Last Closed:||2014-01-31 18:48:52 UTC||Type:||Bug|
|oVirt Team:||---||RHEL 7.3 requirements from Atomic Host:|
|Cloudforms Team:||---||Target Upstream Version:|
Description Cole Robinson 2013-02-28 21:47:22 UTC
Apps like virt-manager want access to the cpu_map.xml, so they can show a pretty list of CPU models to the user. Right now virtinst/virt-manager is hardcoded to look in /usr/share/libvirt/cpu_map.xml, but obviously that a) is fragile b) is broken in the remote case. There should be an API to expose cpu_map.xml. Maybe this is just another call for 'please export XML values in the capabilities XML' or similar
Comment 1 Dave Allan 2013-02-28 21:50:00 UTC
Jiri, would this be a useful addition to the work you're doing with CPU modeling?
Comment 2 Daniel Berrangé 2013-03-01 09:35:51 UTC
I don't think we should extend the capabilities XML, since it is getting rather huge already. We could easily add some new APIs for fetching data though.
Comment 3 Jiri Denemark 2013-03-01 09:41:58 UTC
I think this is one of the things that would fit nicely in a new API for getting emulator capabilities. That would provide a list of CPU models supported by given emulator (in addition to other emulator specific capabilities). And we could perhaps add APIs to expand a CPU model into a list of all CPU features the model supports.
Comment 4 Eric Blake 2013-08-19 19:47:25 UTC
Does the just-added flag extension to virConnectBaselineCPU get us where we want, or is it only part of the solution? https://www.redhat.com/archives/libvir-list/2013-August/msg00150.html That will let you learn all features associated with a given model name, but does not necessarily let you know all model names that have associated features.
Comment 5 Cole Robinson 2014-01-16 21:46:46 UTC
Upstream nowadays has virConnectGetCPUModelNames which solves one part of the problem, virConnectBaselineCPU solves VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES. But there's still no way to have libvirt tell us about all possible feature flags for enumerating in virt-manager. To provide the current UI with a list of features and a checkbox. While people don't need to mess with this much/ever, for things like x2apic which still aren't the default, people want to turn them on.