Bug 916793

Summary: bundle creation fails even when using a valid version string
Product: [JBoss] JBoss Operations Network Reporter: Larry O'Leary <loleary>
Component: ProvisioningAssignee: John Mazzitelli <mazz>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: high Docs Contact:
Priority: unspecified    
Version: JON 3.1.2CC: ahovsepy
Target Milestone: ER01   
Target Release: JON 3.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 916790 Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 916790    
Bug Blocks:    
Attachments:
Description Flags
bundle_version.png
none
bundle_version2.png none

Description Larry O'Leary 2013-02-28 22:35:37 UTC 
+++ This bug was initially created as a clone of RHQ Bug #916790 +++

Created attachment 704013 [details]
see the version string in this bundle's recipe - this causes the error

If I have a bundle whose version string is "3.13.1.201302221022", the bundle fails to be created.

Recipe snippet:

    <rhq:bundle name="Test Version String"
                version="3.13.1.201302221022"
                description="a small bundle with a small.properties file">

The bundle upload wizard gives error:

[Distribution File] Failed to upload bundle distribution file
javax.ejb.EJBException: java.lang.NumberFormatException: For input string: "201302221022"

server log:

17:21:58,004 ERROR [org.jboss.ejb3.invocation] (http--0.0.0.0-7080-1) JBAS014134: EJB Invocation failed on component BundleManagerBean for method public abstract org.rhq.core.domain.bundle.BundleVersion org.rhq.enterprise.server.bundle.BundleManagerLocal.createBundleVersion(org.rhq.core.domain.auth.Subject,int,java.lang.String,java.lang.String,java.lang.String,java.lang.String) throws java.lang.Exception: javax.ejb.EJBException: java.lang.NumberFormatException: For input string: "201302221022"
...
Caused by: java.lang.NumberFormatException: For input string: "201302221022"
	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) [rt.jar:1.7.0_11]
	at java.lang.Integer.parseInt(Integer.java:495) [rt.jar:1.7.0_11]
	at java.lang.Integer.<init>(Integer.java:677) [rt.jar:1.7.0_11]
	at org.apache.maven.artifact.versioning.ComparableVersion.parseItem(ComparableVersion.java:427) [rhq-core-util-4.7.0-SNAPSHOT.jar:4.7.0-SNAPSHOT]
	at org.apache.maven.artifact.versioning.ComparableVersion.parseVersion(ComparableVersion.java:413) [rhq-core-util-4.7.0-SNAPSHOT.jar:4.7.0-SNAPSHOT]
	at org.apache.maven.artifact.versioning.ComparableVersion.<init>(ComparableVersion.java:322) [rhq-core-util-4.7.0-SNAPSHOT.jar:4.7.0-SNAPSHOT]
	at org.rhq.enterprise.server.bundle.BundleManagerBean.createBundleVersion(BundleManagerBean.java:496) [rhq-enterprise-server-ejb3.jar:4.7.0-SNAPSHOT]

Looks like a bug in ComparableVersion.
Comment 1 John Mazzitelli 2013-02-28 22:57:52 UTC 
target release is 3.2 ... we don't have a 3.2 branch yet (right?). This fix is in master. See https://bugzilla.redhat.com/show_bug.cgi?id=916790#c1

"fixed ComparableVersion so it treats long numbers as strings (which is what they probably are meant to be treated as anyway, as in a timestamp such as 201302221030 which refers to 10:30 AM on February 22, 2013.

git commit to master: 8beb34b"

If we have a JON 3.2 branch, that's the commit we need to cherry pick
Comment 2 John Mazzitelli 2013-02-28 22:58:31 UTC 
setting to MODIFIED since I think we wait to put it in ON_QA until it reaches a QA build
Comment 3 Larry O'Leary 2013-09-06 14:30:54 UTC 
As this is MODIFIED or ON_QA, setting milestone to ER1.
Comment 4 Armine Hovsepyan 2013-10-01 14:02:37 UTC 
verified

please get verification screen-shots attached.
Comment 5 Armine Hovsepyan 2013-10-01 14:03:07 UTC 
Created attachment 805988 [details]
bundle_version.png
Comment 6 Armine Hovsepyan 2013-10-01 14:03:36 UTC 
Created attachment 805989 [details]
bundle_version2.png