Bug 916958

Summary: Get error page when adding jenkins client to apps without jenkins server or adding switchyard to non-jboss apps .
Product: OKD Reporter: Mengjiao Gao <mgao>
Component: ContainersAssignee: Jhon Honce <jhonce>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.xCC: dmcphers, jhonce, qgong, szhou, xtian, yujzhang
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-03-15 14:24:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
development.log from /var/log/openshift/site on devenv_2878 none

Description Mengjiao Gao 2013-03-01 10:10:36 UTC
Created attachment 704110 [details]
development.log from /var/log/openshift/site on devenv_2878

Description of problem:
When user tried to add jenkins client to apps without jenkins server, user would always get an error page said "We appear to be having technical difficulties".
The error page and development.log from /var/log/openshift/site is attached.

Version-Release number of selected component (if applicable):
devenv_2878

How reproducible:
always

Steps to Reproduce:
1.Login with the website and make sure there's no jenkins server created by this account.
2.Create an app, and go to the cartridge adding page.
3.Choose to add cartridge jenkins client to the app.
  
Actual results:
3.Got an error page said: "We appear to be having technical difficulties

You can try refreshing the page, if the problem is temporary."

Expected results:
3.User should get page with notice about cannot add jenkins client successfully, and user need to create jenkins server firstly.

Additional info:
This issue exists when users try to add cartridge SwitchYard to non-jboss apps.

Comment 1 Rony Gong 🔥 2013-03-04 07:38:16 UTC
Also test this issue on devenv_2888 by CLI, add switchyard-0.6 to non-supported application, show invalid error message:
[qgong@dhcp-8-169 non_scalable]$ rhc cartridge add -a ruby19 -c switchyard-0.6 -p 111111
Adding switchyard-0.6 to application 'ruby19' ... The server did not respond correctly. This may be an issue with the server configuration or with your connection to the server (such as a Web proxy or firewall). Please verify that your proxy server is working correctly
(http://file.rdu.redhat.com:3128/) and that you can access the OpenShift server https://ec2-23-22-110-226.compute-1.amazonaws.com/broker/rest/domains/qgong1/applications/ruby19/cartridges

Comment 2 Xiaoli Tian 2013-03-04 08:48:44 UTC
Guess this is not a website bug, maybe a node bug or RESTAPI bug, move it to node firstly, feel free to adjust it.

Comment 3 Bill DeCoste 2013-03-04 16:14:57 UTC
Please make this 2 bugs and assign the Jenkins bug to the UI team. The SwitchYard bug is mine.

Comment 4 Jhon Honce 2013-03-04 18:38:55 UTC
Fix in https://github.com/openshift/origin-server/pull/1531

Comment 5 openshift-github-bot 2013-03-04 22:26:15 UTC
Commits pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/f5c0b18767006c99d821865c608e7333b33dc897
Bug 916958, Bug 917513 - V1 Model not honoring Broker contract

* All cartridge stdout messages where not propagated to the Broker when cartridge returned non-zero exit status

https://github.com/openshift/origin-server/commit/d413061989515a92e1b00329ffbb09f216d12e87
Merge pull request #1531 from jwhonce/bug/916958

Bug 916958, Bug 917513 - V1 Model not honoring Broker contract

Comment 6 Mengjiao Gao 2013-03-05 02:11:52 UTC
Verified this bug on devenv_2894 as following steps:

1.Go to website and login with a new account
2.Create a php app
3.Try to add cartridge jenkins-client to php in website
4.Try to add cartridge switchyard to php in website
5.Try to add cartridge switchyard to php using CLI

Actual results:
3.Error message "Invalid cartridge. SwitchYard is only supported for JBoss AS/EAP" was shown correctly.
4.Error message "Invalid cartridge. Jenkins server does not exist! Please create with rhc app create -t jenkins-1.4" was shown correctly

5.[root@dhcp-9-249 ~]# rhc cartridge add switchyard-0.6 -a php
Password: 

Adding 'switchyard-0.6' to application 'php'
Invalid cartridge. SwitchYard is only supported for JBoss AS/EAP