Bug 918410 (RHEV_MigrationStats)

Summary:	[RFE] Improved live migration statistics
Product:	[oVirt] vdsm	Reporter:	Jiri Denemark <jdenemar>
Component:	RFEs	Assignee:	Nobody <nobody>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	medium	Docs Contact:
Priority:	low
Version:	---	CC:	bazulay, bsettle, bugs, cwei, dyuan, jdenemar, knoel, lpeer, mgoldboi, michal.skrivanek, mzhan, srevivo, virt-maint, weizhan
Target Milestone:	---	Keywords:	FutureFeature, Reopened
Target Release:	---	Flags:	ylavi: ovirt-future? rule-engine: planning_ack? rule-engine: devel_ack? rule-engine: testing_ack?
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:	857578	Environment:
Last Closed:	2017-11-16 15:54:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	857577, 857578, 1061570
Bug Blocks:

Description Jiri Denemark 2013-03-06 08:12:22 UTC

VDSM should monitor detailed migration statistics and adjust various parameters (such as XBZRLE cache size) in case migration does not seem to be converging fast enough.

+++ This bug was initially created as a clone of Bug #857578 +++

+++ This bug was initially created as a clone of Bug #857577 +++

Description of problem:

Information about live migration is not available to analyze performance and to tune. Additional statistics should be added.

- Total migration time
- Expected downtime
- Dirty page rate
- Additional stats requested by performance team, partners, libvirt team, etc.

--- Additional comment from Jiri Denemark on 2013-02-25 10:08:47 UTC ---

Implemented upstream by commits v1.0.2-239-g4dd00f4 through v1.0.2-245-g8def329:

commit 8def32916d65ace1e9b0d35f2d71ac2938882c8a
Author: Jiri Denemark <jdenemar>
Date:   Tue Feb 12 20:29:17 2013 +0100

    qemu: Implement virDomainGetJobStats

commit 4121a77c1a9dc477bbbfcac7c44715f78cad4b61
Author: Jiri Denemark <jdenemar>
Date:   Fri Feb 8 09:58:03 2013 +0100

    qemu: Parse more fields from query-migrate QMP command
    
    As a side effect, this also fixes reporting disk migration process.
    It was added to memory migration progress, which was wrong. Disk
    progress has dedicated fields in virDomainJobInfo structure.

commit 38ab12251ecb5ed7d6f12b13047cb15480a3a55b
Author: Jiri Denemark <jdenemar>
Date:   Fri Feb 8 09:55:17 2013 +0100

    virsh: Use virDomainGetJobStats in domjobinfo if available

commit 34fd94278a9f478f59a080640bd8c0317dc13e8d
Author: Jiri Denemark <jdenemar>
Date:   Wed Jan 30 10:49:28 2013 +0100

    remote: Implement virDomainGetJobStats

commit 98b9acf5aa02551dd37d0209339aba2e22e4004a
Author: Jiri Denemark <jdenemar>
Date:   Wed Jan 30 10:28:54 2013 +0100

    remote: Auto-allocate params in remoteDeserializeTypedParameters
    
    remoteDeserializeTypedParameters can now be called with either
    preallocated params array (size of which is announced by nparams) or it
    can allocate params array according to the number of parameters received
    from the server.

commit 8eb7ab95c2d459968bf097dcd2d2bd068a76e628
Author: Jiri Denemark <jdenemar>
Date:   Mon Feb 18 23:20:08 2013 +0100

    python: Implement virDomainGetJobStats wrapper

commit 4dd00f4238df262092550d533496bbf0bc7522a2
Author: Jiri Denemark <jdenemar>
Date:   Sat Jan 26 00:30:49 2013 +0100

    Introduce virDomainGetJobStats API
    
    This is an extensible version of virDomainGetJobInfo.

Comment 1 Michal Skrivanek 2013-03-11 10:17:01 UTC

need to think of reporting some additional info to engine as well

Comment 5 Michal Skrivanek 2014-06-05 08:55:12 UTC

I'd say we best rely on libvirt's autoconvergence implementation

Comment 6 Michal Skrivanek 2014-06-13 10:58:19 UTC

that was a bit too premature. Let's focus on the enhanced monitoring and at least add some more info to the vdsm log. The resulting migration downtime as reported after the migration finishes are tracked as bug 970711

also I don't seem to be able to find any RFE for the XBZRLE compression…will open one

Comment 7 Yaniv Kaul 2017-11-16 12:55:45 UTC

Michal - anything we should do here?

Comment 8 Michal Skrivanek 2017-11-16 15:54:37 UTC

I do not think so, we have post copy and pre-copy enhancements, migration seems to be working reliably today