Bug 918761
| Summary: | nova-manage causes machine to OOM | ||
|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | Jon Thomas <jthomas> |
| Component: | openstack-nova | Assignee: | David Ripton <dripton> |
| Status: | CLOSED ERRATA | QA Contact: | Omri Hochman <ohochman> |
| Severity: | high | Docs Contact: | |
| Priority: | low | ||
| Version: | 2.0 (Folsom) | CC: | apevec, dripton, jhenner, ndipanov, nobody, ohochman |
| Target Milestone: | async | Keywords: | Triaged |
| Target Release: | 2.1 | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | openstack-nova-2012.2.4-4.el6ost | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-05-09 13:54:14 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jon Thomas
2013-03-06 19:58:22 UTC
# rpm -qa | grep nova openstack-nova-common-2012.2.3-4.el6ost.noarch openstack-nova-network-2012.2.3-4.el6ost.noarch openstack-nova-cert-2012.2.3-4.el6ost.noarch openstack-nova-scheduler-2012.2.3-4.el6ost.noarch python-nova-2012.2.3-4.el6ost.noarch openstack-nova-compute-2012.2.3-4.el6ost.noarch openstack-nova-novncproxy-0.4-3.el6ost.noarch openstack-nova-console-2012.2.3-4.el6ost.noarch python-novaclient-2.10.0-4.el6ost.noarch openstack-nova-api-2012.2.3-4.el6ost.noarch The offending code here is:
ips = ({'address': str(address), 'pool': pool, 'interface': interface}
for address in self.address_to_hosts(ip_range))
try:
db.floating_ip_bulk_create(admin_context, ips)
except exception.FloatingIpExists as exc:
# NOTE(simplylizz): Maybe logging would be better here
# instead of printing, but logging isn't used here and I
# don't know why.
print('error: %s' % exc)
sys.exit(1)
This can probably be fixed by just changing ips to be a generator instead of building up the entire list at once before calling the db function.
This is now https://bugs.launchpad.net/nova/+bug/1163394 , assigned to me upstream. The upstream patch-for-review is https://review.openstack.org/25918 The fix got into Havana upstream. commit 34de8d1529fb9a2 I still need to backport it to RHOS. Verified with openstack-nova-2012.2.4-4: [root@puma01 /(keystone_admin)]$ nova-manage --debug floating create 192.168.4.224/2 Command failed, please check log for more info 2013-05-01 15:03:09 CRITICAL nova [req-64e4d334-425a-4941-9815-6cfea67e5155 None None] Invalid input received: Too many IP addresses will be generated. Please increase /2 to reduce the number generated. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2013-0798.html |