Bug 919429 (gimp-dbp)
| Summary: | Review Request: gimp-dbp - David's Batch Processor for the Gimp | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Palle Ravn <ravnzon> |
| Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | hdegoede, luya, notting, package-review |
| Target Milestone: | --- | Flags: | hdegoede:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-04-01 08:04:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Palle Ravn
2013-03-08 12:48:51 UTC
Hi Palle, Palle I think that it is great that you're working on the Fedora Design Packages WishList, as such I would like to Sponsor you. The first step is me reviewing this and your other package submission, then you do a new revision (assuming I'll have some remarks on my first reviews), and I will review the new revision. Rince-repeat until both packages you've submitted are approved. And then once I'm happy with both packages I'll sponsor you and you can continue with the next steps of: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers I'll do a full review of the version you posted in comment 4 later tonight, and let you know what, if anything, needs to be fixed. Regards, Hans Hi,
Full review done:
Good:
- rpmlint checks return:
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2+) OK, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
Needs work:
- Just like with nmon, no COPYING.txt with the gpl text is included, please mail upstream asking them to fix this for the next release
- I don't see the need to remove the .png and empty messages.po, please remove this from %prep
- The %{_libdir}/gimp/2.0/plug-ins dir is owned by the gimp, so the %files section should not own it. Naming the dir in %files will own the dir and all files under it. Instead add the full plugin path to %files
Regards,
Hans
(In reply to comment #2) > Needs work: > - Just like with nmon, no COPYING.txt with the gpl text is included, please > mail upstream asking them to fix this for the next release Doing that now. > - I don't see the need to remove the .png and empty messages.po, please > remove this from %prep Included again. > - The %{_libdir}/gimp/2.0/plug-ins dir is owned by the gimp, so the %files > section should not own it. Naming the dir in %files will own the dir and all > files under it. Instead add the full plugin path to %files dbp appended to ../2.0/plug-ins/ New files: Spec URL: http://dbp.zom.dk/gimp-dbp.spec SRPM URL: http://dbp.zom.dk/gimp-dbp-1.1.9-2.fc18.src.rpm rpmlint: gimp-dbp-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dbp-1.1.9/gui.cc gimp-dbp-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dbp-1.1.9/gui.h gimp-dbp-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dbp-1.1.9/op.cc gimp-dbp-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dbp-1.1.9/op.h gimp-dbp-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dbp-1.1.9/gimpCall.h gimp-dbp-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dbp-1.1.9/dbp.cc gimp-dbp-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dbp-1.1.9/gimpCall.cc 3 packages and 1 specfiles checked; 7 errors, 0 warnings. koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=5135932 Regards Palle (In reply to comment #3) > New files: > Spec URL: http://dbp.zom.dk/gimp-dbp.spec > SRPM URL: http://dbp.zom.dk/gimp-dbp-1.1.9-2.fc18.src.rpm Looks good now, approved! One minor nitpick, in the ChangeLog you write: - Include screenshots - Include translation file This may lead people to think that they are included in the binary packages, which they are not, the only thing which changed is that they are no longer being removed from the builddir in %prep. New Package SCM Request ======================= Package Name: gimp-dbp Short Description: Graphical batch processing for Gimp, no scripting knowledge required Owners: paller Branches: f17 f18 f19 InitialCC: Git done (by process-git-requests). gimp-dbp-1.1.9-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/gimp-dbp-1.1.9-2.fc17 gimp-dbp-1.1.9-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/gimp-dbp-1.1.9-2.fc18 gimp-dbp-1.1.9-2.fc17 has been pushed to the Fedora 17 testing repository. Package Change Request ====================== Package Name: New Branches: Owners: InitialCC: design-sw Include this package as part of design-sw group |