| Summary: | Review Request: R-Rsamtools - R interface to samtools | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
| Component: | Package Review | Assignee: | Pierre-YvesChibon <pingou> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, pingou |
| Target Milestone: | --- | Flags: | pingou:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-09-05 06:16:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 913867 | ||
|
Description
Tom "spot" Callaway
2013-03-08 13:27:19 UTC
Oh, also note, because of the high versioned dependencies here, this will only end up in rawhide/f19 or higher. Going quickly through the spec, couple of questions/remarks:
- The Requires and BuildRequires can probably be cleaned up a little (I see R and R-devel in the BR for example)
- You use %{_bindir}/R but for all the other command you don't specify %{_bindir}, is that on purpose?
The rest of the spec looks fine, but I need to go through the sources and build the package before I approve it.
- Dropped the %{_bindir}, just copy/pasted it from another R specfile.
- Dropped R from BuildRequires
New SPEC: http://spot.fedorapeople.org/R-Rsamtools.spec
SRPM URL: http://spot.fedorapeople.org/R-Rsamtools-1.10.2-2.fc18.src.rpm
Spec is clean, sources seems fine, only two things: a) scratch build fails on F19: http://kojipkgs.fedoraproject.org//work/tasks/193/5210193/build.log missing dependency on http://cran.r-project.org/web/packages/bitops/ apparently b) the license tag says Artistics + LICENSE file which says MIT, but I wonder if that MIT isn't present only because of the samtools which is copied locally. Since we remove that copy, should the license tag in the spec file be simplified to Artistic only? Indeed. Addressed both those issues in -3 (along with fixing the samtools patch): New SPEC: http://spot.fedorapeople.org/R-Rsamtools.spec SRPM URL: http://spot.fedorapeople.org/R-Rsamtools-1.10.2-3.fc18.src.rpm Koji F19 Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5218675 All good then Sha1sum srpm: f2b3ca150c71c034361561bf685c0553e158d9e0 Rsamtools_1.10.2.tar.gz Sha1sum upstream: f2b3ca150c71c034361561bf685c0553e158d9e0 Rsamtools_1.10.2.tar.gz This package is APPROVED For the record, there is already a new version available 1.12.0 part of the new bioconductor release but since all R packages will need a rebuild for R 3.0.0 I thought we could handle updates at the same time. New Package SCM Request ======================= Package Name: R-Rsamtools Short Description: R interface to samtools Owners: spot Branches: f19 InitialCC: Git done (by process-git-requests). R-Rsamtools-1.10.2-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/R-Rsamtools-1.10.2-3.fc19 R-Rsamtools-1.10.2-3.fc19 has been pushed to the Fedora 19 testing repository. Package Change Request ====================== Package Name: R-Rsamtools New Branches: f18 Owners: spot InitialCC: Git done (by process-git-requests). ping ? apparently it's in and build and all, thus closing here. |