Bug 919712

Summary: Review Request: boom - Simple HTTP Load tester
Product: [Fedora] Fedora Reporter: Ralph Bean <rbean>
Component: Package ReviewAssignee: Pierre-YvesChibon <pingou>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: notting, package-review, pingou
Target Milestone: ---Flags: pingou: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-04-10 20:15:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ralph Bean 2013-03-09 18:13:31 UTC
Spec URL: http://ralph.fedorapeople.org//boom.spec
SRPM URL: http://ralph.fedorapeople.org//boom-0.5-1.fc18.src.rpm

Description:
Boom! is a simple command line tool to send some load to a web app.

It is a script you can use to quickly smoke-test your web app
deployment.  Boom! was specifically written to replace my Apache
Bench usage, because I was annoyed by some bugs and some stupid
behaviors.

Comment 1 Ralph Bean 2013-03-09 18:13:35 UTC
This package built on koji:  http://koji.fedoraproject.org/koji/taskinfo?taskID=5099771

Comment 2 Pierre-YvesChibon 2013-03-09 18:16:12 UTC
I'll try to do this soon, but first remark, you may want to reword the description ;-)

Comment 3 Ralph Bean 2013-03-11 14:37:22 UTC
Ha, just letting Tarek's personality shine through.  ;)  Will change it up.

Comment 4 Ralph Bean 2013-03-11 14:41:29 UTC
Spec URL: http://threebean.org/rpm/boom.spec
SRPM URL: http://threebean.org/rpm/boom-0.5-2.fc18.src.rpm

Description:
Boom is a simple command line tool to send some load to a web app.
It is a script you can use to quickly smoke-test your web app
deployment.  Boom was specifically written to replace Apache
Bench usage to get around some bugs and annoyances.

Comment 5 Pierre-YvesChibon 2013-03-11 18:29:36 UTC
- License is valid but indeed your ticket is necessary since the setup.py is the only place it is mentionned (no headers in the file).
- Spec is nice and clear just a few remarks:
  - you can drop the group
  - you can drop the modname macro since we're not using the prefix python- here
- sha1sum:
  Source0 rpm: 0cddb508dea11b6fdc6698abf92df1949a51965a
  Upstream   : 0cddb508dea11b6fdc6698abf92df1949a51965a
- The project builds well on Fedora 18

Looks all good to me: APPROVED

Comment 6 Ralph Bean 2013-03-11 18:45:42 UTC
Thanks, Pierre!  I'll make those changes before import.

New Package SCM Request
=======================
Package Name: boom
Short Description: Simple HTTP Load tester
Owners: ralph
Branches: f18, f17, el6
InitialCC:

Comment 7 Pierre-YvesChibon 2013-03-11 18:48:33 UTC
(In reply to comment #6)
> Branches: f18, f17, el6

You might want to revise that (at least for the moment), python-gevent isn't in EL6

Comment 8 Gwyn Ciesla 2013-03-11 18:49:47 UTC
Git done (by process-git-requests).

Comment 9 Pierre-YvesChibon 2013-03-11 18:51:01 UTC
Just a thought, what about adding a Provides: python-boom for consistency.
It makes sense to have it named boom but knowing our naming scheme some people might search for python-boom.

To be considered

Comment 10 Gwyn Ciesla 2013-03-11 18:57:02 UTC
Canceling flag.

Comment 11 Ralph Bean 2013-03-11 19:14:12 UTC
Agreed on both points (no el6 branch, and Provides: python-boom).

Comment 12 Fedora Update System 2013-03-11 19:55:34 UTC
boom-0.5-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/boom-0.5-2.fc18

Comment 13 Fedora Update System 2013-03-11 19:55:51 UTC
boom-0.5-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/boom-0.5-2.fc17

Comment 14 Fedora Update System 2013-04-01 22:24:41 UTC
boom-0.5-2.fc18 has been pushed to the Fedora 18 stable repository.

Comment 15 Fedora Update System 2013-04-01 22:26:49 UTC
boom-0.5-2.fc17 has been pushed to the Fedora 17 stable repository.