Bug 921660

Summary:	Seam2.3 SeamViewHandler adds conversation id even if conversation is not long running
Product:	[Retired] JBoss Enterprise WFK Platform 2	Reporter:	Marek Schmidt <maschmid>
Component:	Seam	Assignee:	Marek Novotny <mnovotny>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Marek Schmidt <maschmid>
Severity:	medium	Docs Contact:
Priority:	urgent
Version:	2.2.0	CC:	myarboro, ppenicka, rsmeral, snagarwa, tremes
Target Milestone:	ER1
Target Release:	2.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	In previous version of Seam 2.3, the redirect URLs always contained the CID querystring parameter specifying a conversation ID. This happened even when conversations were not long. This has been fixed by changing the SeamViewHandler. As a result, conversation ID is propagated only when necessary.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-07-16 11:32:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	920109, 948732

Description Marek Schmidt 2013-03-14 15:34:54 UTC

Description of problem:

Seam adds conversation id even if the conversation is not long running.

Version-Release number of selected component (if applicable):
WFK 2.2.0.ER2 Seam 2.3.1.Final-redhat-1

Steps to Reproduce:
1. deploy booking example
2. go to http://127.0.0.1:8080/seam-booking/
3. notice that "cid" is in the URL, e.g. http://127.0.0.1:8080/seam-booking/main.seam?cid=2

  
Actual results:
There is a cid in the URL

Expected results:
no cid should be in the URL, as no conversation has begun yet.

Additional Info:

Note that the way how seam propagates conversation id has changed since Seam 2.2, so that now it uses the cid= in places where Seam2.2 would use the page context, so in some cases the "cid" parameter would be correctly present in a Seam2.3 application even if it was not present in the same Seam 2.2 application.

Comment 1 Marek Schmidt 2013-03-20 15:39:06 UTC

Actually, the reproducer is wrong, cid will always be added by a redirect.

To reproduce this issue, do this instead:

1. create a seam-gen WAR application "myproject"
2. create a new action called "myAction" with "seam-gen new-action"
3. deploy with "ant"
4. go to http://127.0.0.1:8080/myproject/myAction.seam
5. click myAction
6. notice the "cid" is in the URL.

Actual results:
There is a cid in the URL

Expected results:
no cid should be in the URL, as no conversation has begun yet.

Comment 2 Marek Novotny 2013-03-25 09:08:45 UTC

Marek S. provided patch, which is good enough to fix this - https://source.jboss.org/changelog/Seam?cs=15466

Comment 3 Marek Schmidt 2013-04-03 08:29:42 UTC

The fix introduced caused regressions in 2.2.0.CR1, see https://bugzilla.redhat.com/show_bug.cgi?id=928557, so this issue has to either be fixed differently, or the fix reverted.

Comment 4 Marek Novotny 2013-04-04 08:50:33 UTC

The fix was reverted in https://source.jboss.org/changelog/Seam?cs=15471

Comment 6 Petr Penicka 2013-04-17 22:39:10 UTC

Edited release note and inserted it into the 2.2.0 RN book.

Docs stage URL: https://documentation-devel.engineering.redhat.com/docs/en-US/JBoss_Web_Framework_Kit/2.2/html-single/2.2.0_Release_Notes/index.html

Build: JBoss_Web_Framework_Kit-2.2.0_Release_Notes-2.2-en-US-0-23

Comment 7 Marek Novotny 2013-05-10 13:29:40 UTC

backported from upstream as https://source.jboss.org/changelog/Seam?cs=15491

Comment 9 JBoss JIRA Server 2013-06-07 13:54:59 UTC

Marek Novotny <mnovotny> updated the status of jira JBSEAM-5083 to Closed

Comment 10 JBoss JIRA Server 2013-06-07 13:54:59 UTC

Marek Novotny <mnovotny> made a comment on jira JBSEAM-5083

2.3.1.CR1 is now out, so closing all resolved issues

Comment 11 Tomas Remes 2013-06-13 08:24:41 UTC

Verified on 2.3.0.ER1 release.

Comment 12 Sneha 2013-07-03 09:45:17 UTC

Updated doc text.