Bug 921985
| Summary: | Review Request: rubygem-foreman_api - Ruby bindings for Forman's rest API | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miroslav Suchý <msuchy> |
| Component: | Package Review | Assignee: | Josef Stribny <jstribny> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hhorak, jstribny, notting, package-review |
| Target Milestone: | --- | Flags: | jstribny:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-04-08 14:06:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Miroslav Suchý
2013-03-15 10:59:50 UTC
Hi, above SRPM URL does not work so I took the one from your koji scratch build. Rpmlint: $ rpmlint rubygem-foreman_api.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint rubygem-foreman_api-0.1.1-5.fc19.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint rubygem-foreman_api-0.1.1-5.fc19.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint rubygem-foreman_api-doc-0.1.1-5.fc19.noarch.rpm rubygem-foreman_api-doc.noarch: W: spelling-error Summary(en_US) api -> pi, ape, apt rubygem-foreman_api-doc.noarch: W: spelling-error %description -l en_US api -> pi, ape, apt rubygem-foreman_api-doc.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Mock: - builds for f17-f19 - works for Ruby < 2 Koji: - builds in rawhide [1] SPEC file: - Looks good. Issues: - I cannot test it against Ruby 2.0 since rubygem-oauth is still not rebuilt. Since rubygem-foreman_api doesn't come up with the test suite I think it's important to wait for all the deps to be rebuilt and present in rawhide to test it more properly. [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=5137620 This is the same as you took from koji, but for sake of correctness: Spec URL: http://miroslav.suchy.cz/fedora/rubygem-foreman_api/rubygem-foreman_api.spec SRC.RPM http://miroslav.suchy.cz/fedora/rubygem-foreman_api/rubygem-foreman_api-0.1.1-5.fc18.src.rpm Thanks Miroslav,
before the rubygem-oauth is rebuilt I have two recommendations for the spec file:
1, %{gem_docdir} could be marked as %doc
Since %{gem_docdir} contains only doc files and no executable files, it should be marked as %doc. From the guidelines [1]: "Any relevant documentation included in the source distribution should be included in the package as %doc"
2, %{gem_cache} should be excluded
%{gem_cache} has no purpose in this RPM and should be excluded.
[1] http://fedoraproject.org/wiki/Packaging:Guidelines
Oauth is already rebuilt. Updated according #3: Spec URL: http://miroslav.suchy.cz/fedora/rubygem-foreman_api/rubygem-foreman_api.spec SRC.RPM http://miroslav.suchy.cz/fedora/rubygem-foreman_api/rubygem-foreman_api-0.1.1-6.fc18.src.rpm Hi, I built it [1] with koji and installed locally using mock. I haven't found any issue so I am APPROVING the package. [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=5224610 New Package SCM Request ======================= Package Name: rubygem-foreman_api Short Description: Ruby bindings for Forman's rest API Owners: msuchy Branches: f18 f19 el6 InitialCC: Git done (by process-git-requests). rubygem-foreman_api-0.1.3-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-foreman_api-0.1.3-1.fc18 rubygem-foreman_api-0.1.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rubygem-foreman_api-0.1.3-1.el6 rubygem-foreman_api-0.1.3-1.fc18 has been pushed to the Fedora 18 stable repository. |