Bug 922033

Summary: Review Request: rubygem-robotex - Ruby library to obey robots.txt
Product: [Fedora] Fedora Reporter: Miroslav Suchý <msuchy>
Component: Package ReviewAssignee: Josef Stribny <jstribny>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: hhorak, jstribny, notting, package-review
Target Milestone: ---Flags: jstribny: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: rubygem-robotex-1.0.0-12.fc18 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-10-01 01:54:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Miroslav Suchý 2013-03-15 12:44:02 UTC
Spec URL: http://miroslav.suchy.cz/fedora/rubygem-robotex/rubygem-robotex.spec
SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-robotex/rubygem-robotex-1.0.0-9.fc18.src.rpm
Description: With one line of code, Robotex (pronounced like “robotics”) will download
and parse the robots.txt file and let you know if your program is allowed
to visit a given link.

Fedora Account System Username: msuchy

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5126038

rpmlint output:
rubygem-robotex.src: W: spelling-error Summary(en_US) txt -> text, ext, tit
rubygem-robotex.src: W: spelling-error %description -l en_US txt -> text, ext, tit
rubygem-robotex.noarch: W: spelling-error Summary(en_US) txt -> text, ext, tit
rubygem-robotex.noarch: W: spelling-error %description -l en_US txt -> text, ext, tit
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

Comment 2 Josef Stribny 2013-03-18 14:58:26 UTC
Rpmlint:

$ rpmlint rubygem-robotex.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint rubygem-robotex-1.0.0-12.fc18.src.rpm 
rubygem-robotex.src: W: spelling-error Summary(en_US) txt -> text, ext, tit
rubygem-robotex.src: W: spelling-error %description -l en_US txt -> text, ext, tit
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Mock:
- builds just fine for f17-f19
- works in mock's irb

Koji:
- builds for rawhide [1] 

SPEC file:
- %{__rm} -Rf %{buildroot}/%{gem_instdir}/.yardoc
  I don't see the point in deleting a user specific .yardoc, it's not necessary in Fedora's spec file and I consider it redundant.

Otherwise it looks good and I am APPROVING this package.

[1] http://koji.fedoraproject.org/koji/taskinfo?taskID=5137477

Comment 3 Miroslav Suchý 2013-03-18 15:16:22 UTC
New Package SCM Request
=======================
Package Name: rubygem-robotex
Short Description: Ruby library to obey robots.txt
Owners: faxguy
Branches: el6 f18 f19
InitialCC:

Comment 4 Gwyn Ciesla 2013-03-18 15:18:31 UTC
Git done (by process-git-requests).

Comment 5 Miroslav Suchý 2013-03-18 16:16:32 UTC
Package Change Request
======================
Package Name: rubygem-robotex
New Branches: 
Owners: msuchy
InitialCC: 

I lamer, I done cat'n'copy SCM Request from one of my previous bugzilla. Unfortunatelly it was bugzilla for which I done review, so the owner was somebody else (faxguy). Please change the ownership to me (msuchy).

Comment 6 Gwyn Ciesla 2013-03-18 16:27:15 UTC
Ownership changes will need to be handled in pkgdb.

Comment 7 Fedora Update System 2013-03-19 17:49:30 UTC
rubygem-robotex-1.0.0-12.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/rubygem-robotex-1.0.0-12.fc18

Comment 8 Fedora Update System 2013-03-19 17:50:37 UTC
rubygem-robotex-1.0.0-12.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/rubygem-robotex-1.0.0-12.el6

Comment 9 Fedora Update System 2013-03-19 21:27:08 UTC
rubygem-robotex-1.0.0-12.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 10 Fedora Update System 2013-10-01 01:54:22 UTC
rubygem-robotex-1.0.0-12.fc18 has been pushed to the Fedora 18 stable repository.

Comment 11 Fedora Update System 2015-11-07 04:01:05 UTC
rubygem-robotex-1.0.0-12.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.