Bug 922186
Summary: | Cgroup audit events with path are not escaped | |||
---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Steve Grubb <sgrubb> | |
Component: | libvirt | Assignee: | Eric Blake <eblake> | |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
Severity: | medium | Docs Contact: | ||
Priority: | high | |||
Version: | 18 | CC: | berrange, clalancette, eblake, itamar, jforbes, jyang, laine, libvirt-maint, veillard, virt-maint | |
Target Milestone: | --- | |||
Target Release: | --- | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | libvirt-0.10.2.5-1.fc18 | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 922203 (view as bug list) | Environment: | ||
Last Closed: | 2013-05-29 00:51:13 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 922203 |
Description
Steve Grubb
2013-03-15 17:06:06 UTC
(In reply to comment #0) > Steps to Reproduce: > 1. Run a vm > 2. ausearch --start recent -m VIRT_RESOURCE -i | grep cgroup | grep '^/dev' Rather, ausearch --start recent -m VIRT_RESOURCE -i | grep cgroup | grep 'path=/dev' Fix proposed here: https://www.redhat.com/archives/libvir-list/2013-April/msg01508.html Backported to v0.10.2-maint; next build will pick this up: commit 31c6bf35b9d9de04158318658f4fbf6a9e54ff28 Author: Eric Blake <eblake> Date: Fri Apr 19 11:30:44 2013 -0600 audit: properly encode device path in cgroup audit https://bugzilla.redhat.com/show_bug.cgi?id=922186 Commit d04916fa introduced a regression in audit quality - even though the code was computing the proper escaped name for a path, it wasn't feeding that escaped name on to the audit message. As a result, /var/log/audit/audit.log would mention a pair of fields class=path path=/dev/hpet instead of the intended class=path path="/dev/hpet", which in turn caused ausearch to format the audit log with path=(null). * src/conf/domain_audit.c (virDomainAuditCgroupPath): Use constructed encoding. Signed-off-by: Eric Blake <eblake> libvirt-0.10.2.5-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libvirt-0.10.2.5-1.fc18 Package libvirt-0.10.2.5-1.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing libvirt-0.10.2.5-1.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-8681/libvirt-0.10.2.5-1.fc18 then log in and leave karma (feedback). libvirt-0.10.2.5-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. |