Bug 922291
| Summary: | Review Request: php-symfony2-PropertyAccess - Symfony2 PropertyAccess Component | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | notting, package-review | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-04-18 05:56:31 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Shawn Iwinski
2013-03-16 01:29:25 UTC
Created attachment 712035 [details]
phpci.log
phpci 2.14.0
Created attachment 712036 [details]
review.txt
Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 922291
No real blocker, but please just answer a few questions before I approve this package I will prefer you don't remove PropertyAccessorCustomArrayObjectTest.php test script but rather remove it only in %check Can't you use the upstream "autoloader.php" instead of building your ? (well, it seems preferable to rely on include_path instead on this stupid file_exists) Why do you edit the phpunit.xml.dist and not simply create a phpunit.xml and add it to the package ? Are .git* files, and role issue reported upstream ? (please add a link to upstream bug) (In reply to comment #3) > No real blocker, but please just answer a few questions before I approve > this package > > I will prefer you don't remove PropertyAccessorCustomArrayObjectTest.php > test script > but rather remove it only in %check The reason why I removed it is because that is the only file causing a circular dependency with the Form component -- it requires one of the Form component's tests [1]. Also, it seems to be an empty test and only caused issues. I will only remove it in %check if you would like, but note that end-user tests will fail as well without having the Form component installed. [1] https://github.com/symfony/symfony/blob/master/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorCustomArrayObjectTest.php#L14 > Can't you use the upstream "autoloader.php" instead of building your ? > (well, it seems preferable to rely on include_path instead on this stupid > file_exists) The supplied autoloader.php works fine in %check with the upstream directory structure, but does not work when PEAR-installed and the tests are in a new location. End-user tests would fail if the custom autoloader was not created and used. > Why do you edit the phpunit.xml.dist and not simply create a > phpunit.xml and add it to the package? No real valid reason why other than allowing the end-user to create their own and keeping the ".dist" as the en-user point-of-view distributed version. I can update the spec to use what you describe. > Are .git* files, and role issue reported upstream ? > (please add a link to upstream bug) I forgot to do that earlier. I just did though... https://github.com/symfony/symfony/issues/7414 Thanks for the explanation, all seems correct. No blocker. === APPROVED === THANKS for the review! New Package SCM Request ======================= Package Name: php-symfony2-PropertyAccess Short Description: Symfony2 PropertyAccess Component Owners: siwinski Branches: f18 f19 el6 InitialCC: Git done (by process-git-requests). |